[OPNFLWPLUG-560] Openflow echo reply processing non-spec compliant Created: 06/Oct/15 Updated: 27/Sep/21 Resolved: 16/Jun/17 |
|
| Status: | Resolved |
| Project: | OpenFlowPlugin |
| Component/s: | General |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Anton Ivanov | Assignee: | Tomas Slusny |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 4422 |
| Description |
|
The echo reply parser does not verify xid. The echo reply is a matching transaction to an echo request. It should carry the same xid as the echo request. ODL does not check the XID of the reply to ensure that the reply corresponds to the request so will keep a connection valid even if the switch is replying with invalid echo replies. |
| Comments |
| Comment by Anton Ivanov [ 15/Oct/15 ] |
|
I am looking through the code and there 3+ implementations of the controller replying to Echo Request which all look OK - they fill the xid and the data correct. I cannot find the incorrect part of the code - the one where the controller should verify that the Echo Reply from the switch is correct and matches the Echo Request. |
| Comment by Dhevendran Kulandaivel [ 18/May/16 ] |
|
(In reply to Anton Ivanov from comment #1) Hi Anton Ivanov I can work on this. Can you provide more details on this Thanks & Regards |
| Comment by Jozef Bacigal [ 05/Jun/17 ] |