[OPNFLWPLUG-598] Longevity He plugin: Null Point Exceptions are seeing at the beginning of the test Created: 19/Jan/16  Updated: 27/Sep/21  Resolved: 30/Jan/16

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Luis Gomez Assignee: Anil Vishnoi
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 5002

 Description   

When we bring 200 switches up and down we see:

2016-01-16 13:45:37,254 | WARN | ds-oper-thread-0 | StatisticsManagerImpl | 155 - org.opendaylight.openflowplugin.applications.statistics-manager - 0.2.0.SNAPSHOT | Unhandled exception during processing statistics. Restarting transaction chain.
java.lang.NullPointerException
at org.opendaylight.openflowplugin.applications.statistics.manager.impl.StatListenCommitQueue$1.applyOperation(StatListenCommitQueue.java:129)[155:org.opendaylight.openflowplugin.applications.statistics-manager:0.2.0.SNAPSHOT]
at org.opendaylight.openflowplugin.applications.statistics.manager.impl.StatisticsManagerImpl.run(StatisticsManagerImpl.java:186)[155:org.opendaylight.openflowplugin.applications.statistics-manager:0.2.0.SNAPSHOT]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)[:1.7.0_85]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)[:1.7.0_85]
at java.lang.Thread.run(Thread.java:745)[:1.7.0_85]

Question is: can we fix this or should we remove this check in the longevity test?

 Comments   
Comment by Anil Vishnoi [ 24/Jan/16 ]

Hi Luis,

This exception can be benign as well, can you point me to the longevity test, need to see why transaction is failing. This should be quick fix i believe.

Comment by Robert Varga [ 24/Jan/16 ]

Any NPE is strictly a bug, as it points to bad code assumptions.

Comment by Jamo Luhrsen [ 25/Jan/16 ]

(In reply to Anil Vishnoi from comment #1)
> Hi Luis,
>
> This exception can be benign as well, can you point me to the longevity
> test, need to see why transaction is failing. This should be quick fix i
> believe.

Anil,

here is the "He plugin" test:
https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-periodic-longevity-only-beryllium

for reference, the "Li plugin" test:
https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-periodic-longevity-lithium-redesign-only-beryllium/

Comment by Jamo Luhrsen [ 25/Jan/16 ]

this also appears to be the bug that causes the link scalability test to fail
in the He plugin:

https://jenkins.opendaylight.org/releng/user/jluhrsen/my-views/view/openflow%20CSIT/job/openflowplugin-csit-1node-periodic-link-scalability-daily-only-beryllium/

The Li Plugin job scales to 1500 links where the test stops because mininet
starts having trouble and takes too long to stop.

Comment by Anil Vishnoi [ 27/Jan/16 ]

This patch will fix it

https://git.opendaylight.org/gerrit/#/c/33534/7

Comment by Luis Gomez [ 30/Jan/16 ]

This is fixed now.

Generated at Wed Feb 07 20:32:53 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.