Operating System: All
Platform: All

patch: https://git.opendaylight.org/gerrit/#/c/37670/

Attachment featuresOrig.dot.svg has been added with description: current state

Attachment featuresNew.dot.svg has been added with description: proposed patch

Can you share more details Michal (Rehak) and Jozef Slezak?

Hi guys,
after discussion w/ Michal I made some regrouping of ofp-features in this patch.

Forwarding-rules-manager bundle was extracted as separate feature on upper level (above the main southbound-li). The same is made with topology-lldp-discovery and topology-manager which are in addition merged along with lldp-speaker into new app feature named app-topology-li. Then the main feature ofp-southbound-li is not dependent on them, but it is dependency of them (see attached diagrams).

So if someone would like to add and use e.g. custom FRM, it's possible to install only the main ofp-southbound-li feature without any default apps and then any particular features/apps/extensions he wants (actual or newly added).

However actual behaviour is still preserved because in flow-services-li installation our default apps and main southbound feature (+dependencies) are included as before.

In addition, I removed unnecessary flow-services-all-li and also nsf-services-li feature where extracted apps where located (unecessary then).

As we decided at the meeting yesterday, it would be better to perform this change after he/li features swap.

I like these changes. You will need a new patch after the He-Li swap as there will be no feature called -Li anymore but you will figure out very easily.

Luis, is it okay removing feature directly rather than deprecating them first and then removing in next release ?

Features is not as critical as API, as long as you make sure downstream projects are not impacted by these changes it is OK.

okay, that's good. I would suggest then we should do the proper cleaning and have some best practices around it. Ideally we should allow user to pick up what they want, and also we should provide wrapper features as well that provides some dedicated functionality using the existing fine grain features. I added couple of comments on the patch as well.

Hi, new patch is there. I made changes according to Anil's comments and also updated dependencies of drop-test feature - it is

...not dependent on the wrapper feature now.

Attachment featuresPatch2.dot.svg has been added with description: patch2

rebased and updated after OFP design swap

Attachment featuresPatch3.dot.svg has been added with description: patch 3

Attachment FeaturesActualMasterDefault.dot.svg has been added with description: features actual master default

Attachment FeaturesRegroupPatch6.dot.svg has been added with description: patch 6 final update

merged