[OPNFLWPLUG-672] Li Migration: New RPC for user-driven statistics collecting Created: 11/Apr/16  Updated: 27/Sep/21  Resolved: 21/Jul/16

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Jozef Bacigal Assignee: Tomas Slusny
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

Issue Links:
Duplicate
is duplicated by OPNFLWPLUG-545 Li:On-demand statistics would be bene... Resolved
is duplicated by OPNFLWPLUG-628 Li Migration: Enabled "get-flow-stati... Resolved
External issue ID: 5692

 Description   

Purpose:

  • enable for user-driven statistics gathering
  • remove deprecated notifications and XID
  • add optional flag to update DS/operational

 Comments   
Comment by Abhijit Kumbhare [ 11/Apr/16 ]

Reference to original bug:

https://bugs.opendaylight.org/show_bug.cgi?id=5432

Comment by Abhijit Kumbhare [ 09/May/16 ]

Hideyuki - can you confirm if this can be done by M4 after the switching the default?

Comment by Hideyuki Tai [ 10/May/16 ]

(In reply to Abhijit Kumbhare from comment #3)
> Hideyuki - can you confirm if this can be done by M4 after the switching the
> default?

Hi Abhijit,

VTN project is ok about that.

Comment by Tomas Slusny [ 13/May/16 ]

GERRIT:
https://git.opendaylight.org/gerrit/#/c/38744
https://git.opendaylight.org/gerrit/#/c/38634

Comment by Shigeru Yasuda [ 20/May/16 ]

Hi,

I found a bug that causes NPE if store-stats is null in RPC input.

If null is returned by input.isStoreStats(), it must be treated as false because definition of store-stats contains "default false;" statement;

I pushed a patch that will fix that bug.

https://git.opendaylight.org/gerrit/39155

Comment by Tomas Slusny [ 20/May/16 ]

(In reply to Shigeru Yasuda from comment #6)
> Hi,
>
> I found a bug that causes NPE if store-stats is null in RPC input.
>
> If null is returned by input.isStoreStats(), it must be treated as false
> because definition of store-stats contains "default false;" statement;
>
> I pushed a patch that will fix that bug.
>
> https://git.opendaylight.org/gerrit/39155

Can I ask, how to reproduce this bug? I was trying to reproduce it, but I am not able to get null in there.

Comment by Shigeru Yasuda [ 20/May/16 ]

(In reply to Tomas Slusny from comment #7)
> Can I ask, how to reproduce this bug? I was trying to reproduce it, but I am
> not able to get null in there.

This bug can be easily reproduced if you write Java code that calls direct stats RPC.

I think this bug cannot be reproduced if you invoke RPC via RESTCONF because RESTCONF will complete missing fields that have default value.

Generated at Wed Feb 07 20:33:05 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.