[OPNFLWPLUG-734] Missing cookie compare in FlowRegistryKeyFactory Created: 19/Jul/16 Updated: 27/Sep/21 Resolved: 22/Jul/16 |
|
| Status: | Resolved |
| Project: | OpenFlowPlugin |
| Component/s: | General |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Tomas Slusny | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 6235 |
| Description |
|
Cookie is sent to constructor when creating FlowRegistryKey, but then it is not used in hashCode() and equals() methods. |
| Comments |
| Comment by Tomas Slusny [ 19/Jul/16 ] |
|
I submitted patch to fix this bug to Gerrit: https://git.opendaylight.org/gerrit/#/c/42036/ |
| Comment by Michal Rehak [ 19/Jul/16 ] |
|
According to openflow spec. v.1.3.2, chapter: 5.2 Flow Table, pg.15: A flow table entry is identified by its match fields and priority: the match fields and priority taken So I believe that cookie should not be a part of flow composite key. On the other hand OVS used to return an error message if controller tried to change cookie value on existing flow. This should be probably retested on current OVS. |