[OPNFLWPLUG-751] Removal of group table with type indirect Created: 22/Aug/16  Updated: 27/Sep/21  Resolved: 12/Dec/17

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Yair Zinger Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


Attachments: File indirect group removal error.pcap    
Issue Links:
Blocks
blocks NETVIRT-91 External network group tables removal... Resolved
External issue ID: 6492

 Description   

When trying to remove a group it uses the group type that the group currently have.
If the group was of type "indirect" it will create an error and will not remove the group (OVS - will give back a GROUPMODFAILED error because of INVALIDGROUP.

According to OpenFlow 1.3 spec when removing a group it should not use any type.



 Comments   
Comment by Shuva Jyoti Kar [ 22/Aug/16 ]

Which version of OVS are you testing against ?

Comment by Yair Zinger [ 22/Aug/16 ]

(In reply to Shuva Jyoti Kar from comment #1)
> Which version of OVS are you testing against ?

2.5.1

Comment by Shuva Jyoti Kar [ 22/Aug/16 ]

(In reply to Yair Zinger from comment #2)
> (In reply to Shuva Jyoti Kar from comment #1)
> > Which version of OVS are you testing against ?
>
> 2.5.1

could you please attach the Wireshark capture of the same to the bug

Comment by Yair Zinger [ 22/Aug/16 ]

See packets number 216 and 218

Comment by Yair Zinger [ 22/Aug/16 ]

Attachment indirect group removal error.pcap has been added with description: indirect group removal error pcap

Comment by Yair Zinger [ 22/Aug/16 ]

(In reply to Shuva Jyoti Kar from comment #3)
> (In reply to Yair Zinger from comment #2)
> > (In reply to Shuva Jyoti Kar from comment #1)
> > > Which version of OVS are you testing against ?
> >
> > 2.5.1
>
> could you please attach the Wireshark capture of the same to the bug

Yes, I've attached it.

Comment by Shuva Jyoti Kar [ 22/Aug/16 ]

Perhaps this could help

http://openvswitch.org/pipermail/dev/2016-March/067852.html

I remember that the patch was merged sometime in April , but couldnot find it out.

Comment by Yair Zinger [ 23/Aug/16 ]

(In reply to Shuva Jyoti Kar from comment #6)
> Perhaps this could help
>
> http://openvswitch.org/pipermail/dev/2016-March/067852.html
>
> I remember that the patch was merged sometime in April , but couldnot find
> it out.

It's good that this was reported.
But it we still have a problem in the 2.5 official release and 2.4 OVS versions and the spec says to ignore the type, maybe we should always use "all" type for groups removal?

Comment by Alon Kochba [ 31/Aug/16 ]

FYI we decided to workaround NETVIRT-91 by using "all" group with a single bucket instead of "indirect" in netvirt, so no need for this in Boron from our side.

We should probably do something with this in openflowplugin for Carbon (use all when deleting indirect? verify fix of delete with indirect in OVS2.6?)

Comment by Andrej Leitner [ 22/Sep/16 ]


Is this a bug in ovs?

Comment by Yair Zinger [ 22/Sep/16 ]

(In reply to Andrej Leitner from comment #9)
> Is this a bug in ovs?

According to the openflow spec the switch should ignore it.
However, this is not fixed in OVS 2.4 and 2.5 official releases.

I think it will be best if we support the use of OVS 2.4 and 2.5.

In addition, there's a bug in ODL:
When trying to remove a group and specifically use a type for the removal it ignore it and use the type that was used for the group installation.

Comment by Andrej Leitner [ 22/Sep/16 ]

We should definitely fix ODL/OFP bugs, but in general, I don't think it is good idea to adjust our code to work with different bugs in other related systems.

Comment by Shuva Jyoti Kar [ 22/Sep/16 ]

(In reply to Andrej Leitner from comment #9)
> Is this a bug in ovs?

Yes that's fixed as a part of
https://github.com/openvswitch/ovs/commit/beaa2b8702a20fa1f55e3b4c072dfe6fa394d6d1

Comment by Shuva Jyoti Kar [ 22/Sep/16 ]

(In reply to Yair Zinger from comment #10)
> (In reply to Andrej Leitner from comment #9)
> > Is this a bug in ovs?
>
> According to the openflow spec the switch should ignore it.
> However, this is not fixed in OVS 2.4 and 2.5 official releases.
>
> I think it will be best if we support the use of OVS 2.4 and 2.5.
>
> In addition, there's a bug in ODL:
> When trying to remove a group and specifically use a type for the removal it
> ignore it and use the type that was used for the group installation.

Could you please rephrase the question?

Comment by Andrej Leitner [ 22/Sep/16 ]

It was reaction to:

(In reply to Yair Zinger from comment #7)
> It's good that this was reported.
> But it we still have a problem in the 2.5 official release and 2.4 OVS
> versions and the spec says to ignore the type, maybe we should always use
> "all" type for groups removal?

Comment by Anil Vishnoi [ 12/Dec/17 ]

No activity on this bug from last 1 year, closing the bug. Please re-open the bug if you see this issue with carbon/nitrogen/oxygen branch.

Generated at Wed Feb 07 20:33:18 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.