[OPNFLWPLUG-857] OpenFlowPluginProviderImpl.setFlowRemovedNotification performs self-assignment Created: 20/Feb/17  Updated: 27/Sep/21  Resolved: 03/Mar/17

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Jim West Assignee: Jim West
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 7822

 Description   

Looking at Boron-SR2,
./openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/OpenFlowPluginProviderImpl.java, line 180.

I believe this method is incorrect:
public void setFlowRemovedNotification(boolean isFlowRemovedNotificationOn)

{ this.isFlowRemovedNotificationOn = this.isFlowRemovedNotificationOn; }

It should be
public void setFlowRemovedNotification(final boolean isFlowRemovedNotificationOn)

{ this.isFlowRemovedNotificationOn = isFlowRemovedNotificationOn; }

As it is currently coded, it does not function as intended.

 Comments   
Comment by Jim West [ 20/Feb/17 ]

This defect was caused by this commit:
https://github.com/opendaylight/openflowplugin/commit/a47ccf345dcabb0dbd3f2b15cce79e587149c572

In Nov 2016

Comment by Tomas Slusny [ 22/Feb/17 ]

I fixed this issue as part of this patch: https://git.opendaylight.org/gerrit/#/c/50819/ because I do not knew that there is already bug reported for it, and creating new bug was not worth it for that small issue. So, when that patch will be merged, this bug can be closed.

Comment by Miroslav Macko [ 03/Mar/17 ]

Patch https://git.opendaylight.org/gerrit/#/c/50819/ has been merged.

Generated at Wed Feb 07 20:33:34 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.