[OPNFLWPLUG-862] reg matches with a mask causes a flood of "Message deserialization failed" exceptions Created: 03/Mar/17 Updated: 27/Sep/21 Resolved: 16/Mar/17 |
|
| Status: | Resolved |
| Project: | OpenFlowPlugin |
| Component/s: | General |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Janki Chhatbar | Assignee: | Tomas Slusny |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| Attachments: |
|
| External issue ID: | 7897 |
| Description |
|
Message deserialization failed |
| Comments |
| Comment by Koby Aizer [ 09/Mar/17 ] |
|
Attachment flowstats1.pcap has been added with description: flow stats that cause the exception |
| Comment by Koby Aizer [ 09/Mar/17 ] |
|
I looked into this exception a little bit, and I think it is caused by flow stats received from table=49. This table includes the rules like: I've tcpdumped the flowstats, and for some reason the REG1 OXM value is 8byte long, while openflowplugin assumes it is 4byte long - and I think this causes the decoder to fail (the exception is just a side effect of the decoder trying to decode the additional 4bytes as the next OXM field) . Attached a pcap of the problematic flow stats (look for the REG1 OXM match under table=49) |
| Comment by Koby Aizer [ 13/Mar/17 ] |
|
Updated the bug title to be more informative, and moving bug to openflowplugin. It seems like the 4byte/8byte difference I noted earlier is because the REG1 match was masked. Therefore, the OXM data is 8byte long (4byte value + 4byte mask). It seems like this wasn't taken into account when decoding the OXM. |
| Comment by Janki Chhatbar [ 14/Mar/17 ] |
|
Hi Tomas, Are you working on this? I was working on it. Not sure why I was unassigned from this bug. We can work together if you haven't still submitted the patch. If you have, please share its link. |
| Comment by Tomas Slusny [ 14/Mar/17 ] |
|
You was assigned to it, but it was not in progress, so I assumed that no one is working on it. Yes, I already made patch for it, and also Guarav made patch for it, so I don't know, I can abandon mine patch. Anyway, here is link to Guarav's patch: https://git.opendaylight.org/gerrit/#/c/51936/ and here is link to mine: https://git.opendaylight.org/gerrit/#/c/51936/. |
| Comment by Tomas Slusny [ 14/Mar/17 ] |
|
| Comment by Jamo Luhrsen [ 15/Mar/17 ] |
|
(In reply to Tomas Slusny from comment #6) looks to have worked. here is patch test job's karaf.log without these exceptions just go back one job if you want to double check how it was Much appreciated Tomas! |
| Comment by Janki Chhatbar [ 15/Mar/17 ] |
|
Works in local CSIT environment too. Thanks Tomas! |
| Comment by Tomas Slusny [ 16/Mar/17 ] |
|
Patch was merged, so based on comments I think I can close this. |