[OPNFLWPLUG-878] Direct statistics RPCs do not return error information on failure Created: 12/Apr/17  Updated: 27/Sep/21  Resolved: 25/Apr/17

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Shigeru Yasuda Assignee: Shigeru Yasuda
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 8217

 Description   

Direct statistics RPCs do not provide any error information when it fails.

For example, get-queue-statistics RPC should fail if the specified queue does not exist.

POST /restconf/operations/opendaylight-direct-statistics:get-queue-statistics
Body:
{
"input":

{ "node": "/opendaylight-inventory:nodes/opendaylight-inventory:node[opendaylight-inventory:id=\"openflow:1\"]", "node-connector-id": "1", "queue-id": "12345" }

}

If the queue ID 12345 does not exist on the port "openflow:1:1", OF switch will return QUEUE_OP_FAILED/BAD_QUEUE error. But get-queue-statistics RPC returns an empty response.

HTTP/1.1 200 OK
Content-Type: application/yang.operation+json
Content-Length: 0
Server: Jetty(8.1.19.v20160209)

 Comments   
Comment by Shigeru Yasuda [ 12/Apr/17 ]

https://git.opendaylight.org/gerrit/54868 (master)

Comment by Shigeru Yasuda [ 12/Apr/17 ]

(In reply to Shigeru Yasuda from comment #1)
> https://git.opendaylight.org/gerrit/54868 (master)

After applying this patch, above get-queue-statistics RPC returns the following response.

HTTP/1.1 500 Server Error
Content-Type: application/json
Transfer-Encoding: chunked
Server: Jetty(8.1.19.v20160209)

{
"errors":{
"error":[
{
"error-type":"application",
"error-tag":"operation-failed",
"error-message":"Device reported error type QUEUEOPFAILED code BADQUEUE",
...

Comment by Shigeru Yasuda [ 13/Apr/17 ]

https://git.opendaylight.org/gerrit/54924 (stable/carbon)
https://git.opendaylight.org/gerrit/54933 (stable/boron)

Comment by Tomas Slusny [ 25/Apr/17 ]

Merged on all 3 branches, so this can be closed then, right?

Comment by Shigeru Yasuda [ 25/Apr/17 ]

(In reply to Tomas Slusny from comment #4)
> Merged on all 3 branches, so this can be closed then, right?

Yes. Thanks for your review.

Generated at Wed Feb 07 20:33:37 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.