[OPNFLWPLUG-905] ContextChain closing is not closing everything properly Created: 12/Jun/17  Updated: 27/Sep/21  Resolved: 26/Jun/17

Status: Resolved
Project: OpenFlowPlugin
Component/s: General
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Tomas Slusny Assignee: Tomas Slusny
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 8668

 Description   

Currently, when closing ContextChain (that holds other contexts, like DeviceContext, StatisticsContext, RpcContext) is not terminating everything properly. This can lead to issues during connection flapping, leftover entries in operational/ds and possible freeze of ClusterSingletonService. These are issues that I reproduced locally.

What needs to be fixed is:

  • Terminate transaction chain when device context is closed, but do not write data to datastore if initial submit was not done yet
  • Do not close registration to cluster singleton service during calling instantiateServiceInstance, because there is lock in ClusterSingletonService, that can freeze ClusterSingletonService when this happens
  • Add queue for setting SLAVE on device when device not yet got MASTER, because when many devices connects at once, it is possible that we hit end of timer when device is connected and so we immediately set SLAVE on device and then replace it with MASTER
  • Wait for RPC services to be registered before we will send nodeAddedNotification to FRM so FRM will have all RPC services available to it
  • Unregister RPC registrations when RpcContext is closed but was never MASTER
  • Always remove device from DS when we got lost owner from EOS
  • Prevent propagation of device disconnected even multiple times (add checks if connection state is RIP directly into ConnectionContext)


 Comments   
Comment by Tomas Slusny [ 12/Jun/17 ]

GERRIT: https://git.opendaylight.org/gerrit/#/c/57814/

Comment by Tomas Slusny [ 26/Jun/17 ]

Patch was merged, closing.

Generated at Wed Feb 07 20:33:41 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.