[OPNFLWPLUG-975] Groups do not clear from operational DS when removed from config DS Created: 08/Feb/18 Updated: 24/Feb/18 Resolved: 24/Feb/18 |
|
| Status: | Verified |
| Project: | OpenFlowPlugin |
| Component/s: | statistics-manager |
| Affects Version/s: | None |
| Fix Version/s: | Carbon-SR3 |
| Type: | Bug | Priority: | Highest |
| Reporter: | Luis Gomez | Assignee: | Sunil Kumar M S |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
This issue is tracked in this test: To reproduce just push a group and remove it from config DS. The group will never clear from operational DS. |
| Comments |
| Comment by Anil Vishnoi [ 09/Feb/18 ] |
|
This is the gerrit that is causing the regression.
|
| Comment by Anil Vishnoi [ 09/Feb/18 ] |
|
sunilkumarms can you please have a look at this regression, looks like it's sneaked in through the patch you pushed. |
| Comment by Sunil Kumar M S [ 11/Feb/18 ] |
|
ecelgp can you let me know what is the exact issue you are observing. can you point me to the logs where i can see which groups are remaining in DS for which DPN. Can you reproduce the problem in DEBUG mode on "org.opendaylight.openflowplugin.impl" |
| Comment by Luis Gomez [ 12/Feb/18 ] |
|
Hi Sunil, the issue is very easy to reproduce: 1) start mininet 1 switch: sudo mn --controller 'remote,ip=192.168.0.1,port=6633' --topo linear,1 --switch ovsk,protocols=OpenFlow13 2) Add one group via REST: PUT http://127.0.0.1:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:1/group/1 <group xmlns="urn:opendaylight:flow:inventory"> <group-type>group-select</group-type> <buckets> <bucket> <weight>1</weight> <action> <output-action> <output-node-connector>1</output-node-connector> </output-action> <order>1</order> </action> <bucket-id>1</bucket-id> </bucket> <bucket> <weight>1</weight> <action> <output-action> <output-node-connector>2</output-node-connector> </output-action> <order>1</order> </action> <bucket-id>2</bucket-id> </bucket> </buckets> <barrier>false</barrier> <group-name>Foo</group-name> <group-id>1</group-id> </group> 3) Check the group is in operational:
GET http://127.0.0.1:8181/restconf/operational/opendaylight-inventory:nodes/node/openflow:1/group/1
4) Remove the group:
DELETE http://127.0.0.1:8181/restconf/config/opendaylight-inventory:nodes/node/openflow:1/group/1
5) Check group is still in operational:
GET http://127.0.0.1:8181/restconf/operational/opendaylight-inventory:nodes/node/openflow:1/group/1
|
| Comment by Sunil Kumar M S [ 12/Feb/18 ] |
|
ecelgp Avishnoi analyzed the issue. Looks like if there is only one group installed on switch and if the same is being deleted, it will not be removed from OperDS also that on deleting the lone group, statistics will be empty and empty data will not be written to operDS. both ways group remains in operDS. |
| Comment by Kit Lou [ 13/Feb/18 ] |
|
What's the next action we need to take here? Do we need any code fix? Thanks! |
| Comment by Sunil Kumar M S [ 14/Feb/18 ] |
|
klou we have a fix for it https://git.opendaylight.org/gerrit/#/c/68130/ but test are failing Running org.opendaylight.odlparent.featuretest.SingleFeatureTest Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1,051.615 sec <<< FAILURE! - in org.opendaylight.odlparent.featuretest.SingleFeatureTest installFeature(org.opendaylight.odlparent.featuretest.SingleFeatureTest)[repoUrl: file:/w/workspace/openflowplugin-distribution-check-carbon/distribution/features3-test/target/classes/features.xml, Feature: odl-integration-compatible-with-all 0.6.3-SNAPSHOT] Time elapsed: 630.301 sec <<< ERROR! java.lang.ClassNotFoundException: org.junit.runners.model.TestTimedOutException (no security manager: RMI class loader disabled) at sun.rmi.server.LoaderHandler.loadClass(LoaderHandler.java:396) at sun.rmi.server.LoaderHandler.loadClass(LoaderHandler.java:186) |
| Comment by Luis Gomez [ 14/Feb/18 ] |
|
We need this patch: https://git.opendaylight.org/gerrit/#/c/68226 for the verify job to pass. |
| Comment by Luis Gomez [ 14/Feb/18 ] |
|
We also need ovsdb succesful merge job: https://jenkins.opendaylight.org/releng/view/Merge-Jobs/job/ovsdb-merge-carbon/ |
| Comment by Kit Lou [ 14/Feb/18 ] |
|
sunilkumarms - Can you re-run your test for the fix? I believe the 2 items Luis mentioned are in place. Thanks! |
| Comment by Kit Lou [ 24/Feb/18 ] |
|
Can we close this issue out as SR3 was already released? |