From: Mathieu Lemay <mlemay@inocybe.com>
Subject: Re: question on System.getProperty() and Karaf's custom.properties
Date: October 15, 2014 at 12:44:57 PM GMT-3
To: Srini Seetharaman <srini.seetharaman@gmail.com>
Cc: Flavio Fernandes <ffernand@redhat.com>, Sam Hague <shague@redhat.com>
Yes .. system:property would work 
to get that in config you will want to copy over system.properties file and override that in the distro... I had it this way but Ed chopped it as he wanted to avoid system.properties customization. The files are not equivalent and not loaded at the same time. So the other approach is to cope the system.properties file but that will make things a little more difficult..
Cheers
Mathieu
On Wed, Oct 15, 2014 at 11:34 AM, Srini Seetharaman <srini.seetharaman@gmail.com> wrote:
Hi Matt
I performed the following in karaf:
opendaylight-user@root>system:property ovsdb.l3.fwd.enabled yes
opendaylight-user@root>feature:install odl-ovsdb-openstack
That printed in the karaf.log "OVSDB L3 forwarding is enabled" So I could still use System.getProperty() right?
I would prefer to have a workaround for those using Helium that doesn't have the BundleContext.getProperty fix.
Flavio - Here is the bug: https://bugs.opendaylight.org/show_bug.cgi?id=2192
Srini.
On Wed, Oct 15, 2014 at 4:34 AM, Flavio Fernandes <ffernand@redhat.com> wrote:
Thanks, Mat!
I will take care of this when once I get home.
Srini: I have not opened the bug for this yet. Sorry!
– flavio
On Oct 14, 2014, at 9:54 PM, Mathieu Lemay <mlemay@inocybe.com> wrote:
I am the right guy to ask but just long delays for answers .. This is normal only system.properties make it into System.getProperty(). Your settings should be available under BundleContext.getProperty API..
Let me know if you still.have issues...
Cheers
Mathieu
On Oct 14, 2014 3:01 PM, "Flavio Fernandes" <ffernand@redhat.com> wrote:
Hi Mat,
This may be unrelated to your area of expertise; so please feel to tell me I’m asking the wrong person.
When ovsdb was distributed under osgi, we used a config file called:
…/controller.git/opendaylight/distribution/opendaylight/src/main/resources/configuration/config.ini
to store things like "ovsdb.listenPort=6640”
In Helium, with the introduction of Karaf, the ‘place’ where this config is stored looks to be at:
…/controller.git/opendaylight/distribution/opendaylight-karaf-resources/src/main/resources/etc/custom.properties
however, what I observe when debugging the code that uses the config is that no ovsdb related config
is present via the System.getProperty() API:
...
private static void startOvsdbManager() {
String portString = System.getProperty(OVSDB_LISTENPORT);
if (portString != null)
…
Do you know much about ‘custom.properties’ ? Is the code above not proper for looking for key/data values?
Thanks!
— flavio
Fixed on master and stable/helium.
https://git.opendaylight.org/gerrit/#/c/12055/
https://git.opendaylight.org/gerrit/#/c/12058/
Part 2 fixed on master and stable/helium.
https://git.opendaylight.org/gerrit/#/c/12176/
https://git.opendaylight.org/gerrit/#/c/12225/