[OVSDB-132] ArpResponderService.programStaticArpEntry(ArpResponderService.java is using illegal string format to represent inet prefix Created: 03/Dec/14  Updated: 19/Oct/17  Resolved: 12/Jun/15

Status: Resolved
Project: ovsdb
Component/s: Neutron
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Flavio Fernandes Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

Issue Links:
Blocks
blocks OPNFLWPLUG-330 opendaylight-action-types.yang: ipv[4... Resolved
is blocked by OVSDB-141 Helium SR2 is missing the openflow me... Resolved
is blocked by YANGTOOLS-317 Generated types fail to validate stri... Resolved
Duplicate
is duplicated by OVSDB-141 Helium SR2 is missing the openflow me... Resolved
External issue ID: 2460

 Description   

OVSDB code is not providing valid string to represent prefix, or should be using inetAddress instead of inetPrefix

org.opendaylight.ovsdb.openstack.net-virt - 1.1.0.SNAPSHOT | Router interface e87bb7ca-cd60-44dd-be1e-4dd7998e5639 got event UPDATE. Subnet c8f0a699-8e6c-4afa-ac26-a809068ef08d
2014-12-02 18:42:11,733 | ERROR | pool-41-thread-1 | SouthboundHandler | 345 - org.opendaylight.ovsdb.openstack.net-virt - 1.1.0.SNAPSHOT | Exception caught in ProcessRowUpdate for node OVS|192.168.50.20:48314
java.lang.IllegalArgumentException: Supplied value "10.0.0.1" does not match any of the permitted patterns [^(([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])\.)

{3}

([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])/(([0-9])|([1-2][0-9])|(3[0-2]))$]
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:119)[122:com.google.guava:14.0.1]
at org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.Ipv4Prefix.<init>(Ipv4Prefix.java:52)[207:org.opendaylight.yangtools.model.ietf-inet-types:2010.09.24.7-SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.providers.openflow13.services.ArpResponderService.programStaticArpEntry(ArpResponderService.java:76)[346:org.opendaylight.ovsdb.openstack.net-virt-providers:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.programStaticArpStage2(NeutronL3Adapter.java:651)[345:org.opendaylight.ovsdb.openstack.net-virt:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.programStaticArpStage1(NeutronL3Adapter.java:632)[345:org.opendaylight.ovsdb.openstack.net-virt:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.programFlowsForNeutronRouterInterface(NeutronL3Adapter.java:431)[345:org.opendaylight.ovsdb.openstack.net-virt:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.handleNeutronRouterInterfaceEvent(NeutronL3Adapter.java:184)[345:org.opendaylight.ovsdb.openstack.net-virt:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.handleNeutronPortEvent(NeutronL3Adapter.java:158)[345:org.opendaylight.ovsdb.openstack.net-virt:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.handleInterfaceEvent(NeutronL3Adapter.java:247)[345:org.opendaylight.ovsdb.openstack.net-virt:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.SouthboundHandler.handleInterfaceUpdate(SouthboundHandler.java:242)[345:org.opendaylight.ovsdb.openstack.net-virt:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.SouthboundHandler.processRowUpdate(SouthboundHandler.java:193)[345:org.opendaylight.ovsdb.openstack.net-virt:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.SouthboundHandler.processEvent(SouthboundHandler.java:359)[345:org.opendaylight.ovsdb.openstack.net-virt:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.dispatchEvent(EventDispatcherImpl.java:92)[345:org.opendaylight.ovsdb.openstack.net-virt:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.access$100(EventDispatcherImpl.java:28)[345:org.opendaylight.ovsdb.openstack.net-virt:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl$1.run(EventDispatcherImpl.java:55)[345:org.opendaylight.ovsdb.openstack.net-virt:1.1.0.SNAPSHOT]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)[:1.7.0_67]
at java.util.concurrent.FutureTask.run(FutureTask.java:262)[:1.7.0_67]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)[:1.7.0_67]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)[:1.7.0_67]
at java.lang.Thread.run(Thread.java:745)[:1.7.0_67]

 Comments   
Comment by Flavio Fernandes [ 03/Dec/14 ]

[18:43:25] <flaviof> just tries master. Hit a new issue: https://gist.github.com/901661aa171230e3f357
[18:43:49] <edwarnicke> Interesting...
[18:43:55] <flaviof> Ipv4Prefix.java
[18:44:02] flaviof looking
[18:44:20] <edwarnicke> So that looks like a symptom of the IPv6 fix that Ryan did... which did pass tempest (but I presume that's only the ML2 driver)
[18:44:33] <flaviof> interesting
[18:44:48] <edwarnicke> Oh wait
[18:44:50] <edwarnicke> That's not it
[18:44:54] <edwarnicke> Looking at it a second time
[18:45:02] <edwarnicke> I think I may know what's happening here
[18:45:09] <edwarnicke> Ah
[18:45:10] <flaviof> 2014-12-02 18:42:11,733 | ERROR | pool-41-thread-1 | SouthboundHandler | 345 - org.opendaylight.ovsdb.openstack.net-virt - 1.1.0.SNAPSHOT | Exception caught in ProcessRowUpdate for node OVS|192.168.50.20:48314
[18:45:10] <flaviof> java.lang.IllegalArgumentException: Supplied value "10.0.0.1" does not match any of the permitted patterns [^(([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])\.)

{3}

([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])/(([0-9])|([1-2][0-9])|(3[0-2]))$]
[18:45:14] <edwarnicke> Yes
[18:45:16] <flaviof> yang changes?
[18:45:23] <edwarnicke> Actually a bugfix
[18:45:28] <flaviof> lol
[18:45:45] <edwarnicke> IPPrefix has a pattern that restricts it to an actual IPPrefix ( things like 10.0.0.1/32 for example)
[18:45:54] <edwarnicke> But that prefix was not properly enforced
[18:45:58] <edwarnicke> There was a bug fix to fix that
[18:46:01] <flaviof> gotcha. make sense
[18:46:34] <flaviof> you are right... a prefix w/out a mask is just wrong
[18:46:35] <edwarnicke> I'm going to guess here that you guys where using IPv4Prefix, when you should have been using IPv4Address
[18:46:45] <edwarnicke> And that you had things like 10.0.0.1 in it

Comment by Flavio Fernandes [ 03/Dec/14 ]

https://git.opendaylight.org/gerrit/13329

Generated at Wed Feb 07 20:35:35 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.