[OVSDB-3] Please convert System.out.println usage to proper log statements Created: 15/Jan/14  Updated: 03/May/18  Resolved: 21/Mar/14

Status: Resolved
Project: ovsdb
Component/s: API
Affects Version/s: unspecified
Fix Version/s: None

Type: Improvement
Reporter: Ed Warnicke Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Mac OS
Platform: PC



 Description   

Please convert System.out.println usage to proper log statements:

Subdir ovsdb/
Running command: grep -rn System.out .
./ovsdb/src/main/java/org/opendaylight/ovsdb/plugin/NodeDB.java:69: MapUtils.debugPrint(System.out, null, schema.getTables());
./ovsdb/src/main/java/org/opendaylight/ovsdb/plugin/NodeDB.java:70: MapUtils.debugPrint(System.out, null, cache);
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/jsonrpc/TestClient.java:73: System.out.println("data counter = " + counter);
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/jsonrpc/TestClient.java:86: System.out.println("partial first half counter = " + counter);
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/jsonrpc/TestClient.java:95: System.out.println("partial second half counter = " + counter);
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/jsonrpc/TestTokens.java:30: System.out.println(get.getRawType());
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/jsonrpc/TestTokens.java:34: System.out.println("get1 = " + get1);
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/message/MonitorResponseTest.java:63: System.out.println("interfaceRow = " + interfaceRow);
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/message/MonitorResponseTest.java:69: System.out.println("optE.getKey() = " + optE.getKey());
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/message/MonitorResponseTest.java:70: System.out.println("optE.getValue() = " + optE.getValue());
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/message/OVSDBNettyFactoryIT.java:101: MapUtils.debugPrint(System.out, null, databaseSchema.getTables());
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/message/OVSDBNettyFactoryIT.java:111: System.out.println("Monitor Request sent :");
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/message/OVSDBNettyFactoryIT.java:174: System.out.println("Transcation sent :");
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/message/OVSDBNettyFactoryIT.java:176: System.out.println("Transaction response : "+transResponse.toString());
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/message/OVSDBNettyFactoryIT.java:182: System.out.println("Request + Response : "+requests.toString());
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/message/OVSDBNettyFactoryIT.java:184: System.out.println("ERROR : "+tr.get(tr.size()-1).getError());
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/message/OVSDBNettyFactoryIT.java:185: System.out.println("Details : "+tr.get(tr.size()-1).getDetails());
./ovsdb/src/test/java/org/opendaylight/ovsdb/lib/message/OVSDBNettyFactoryIT.java:192: System.out.printf("Result of echo is %s \n", s);
./ovsdb/src/test/java/org/opendaylight/ovsdb/plugin/OVSDBTestGetBridgeDomainsIT.java:41: System.out.println(ls);



 Comments   
Comment by Sheena goyal [ 17/Jan/14 ]

I have submitted the required changes for this enhancement in gerrit.
https://git.opendaylight.org/gerrit/#/c/4340/

After the code review and submission, I will close this.

Comment by Sheena goyal [ 22/Jan/14 ]

Please suggest further as all the changes that are mentioned below in the test files are not required as updated by Venu.so when can I close this??

Comment by Dave Tucker [ 21/Mar/14 ]

Based on the discussion in https://git.opendaylight.org/gerrit/#/c/4340/ closing this as won't fix as these statements only appear in unit/integration tests.

Generated at Wed Feb 07 20:35:15 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.