[OVSDB-327] QoS and Queues not removed from operational after delete when using OVS 2.5 docker image Created: 04/Apr/16 Updated: 29/May/18 Resolved: 05/Apr/16 |
|
| Status: | Resolved |
| Project: | ovsdb |
| Component/s: | Southbound.Open_vSwitch |
| Affects Version/s: | unspecified |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Josh Hershberg | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 5648 |
| Description |
|
Bug was observed in southbound-it. Specifically in SouthboundIT.testAddDeleteQueue and SouthboundIT.testAddDeleteQoS but also in other tests. Root cause is code in the execute method of OvsdbQoSRemovedCommand and OvsdbQueueRemovedCommand. The deleteQoS/Queue methods are only called if the update notification contains modifications to the OpenVSwitch table. My guess is that in 2.5 OVS optimizes the notification out for the OpenVSwitch table because although an update was sent to OVS, data was not changed. |
| Comments |
| Comment by Josh Hershberg [ 04/Apr/16 ] |
|
Patch is on it's way in |
| Comment by Josh Hershberg [ 04/Apr/16 ] |
|
Changing the logic to no longer depend on there also being changes to the OpenVSwitch table solves this issue. However, I am not sure if the issue is caused by version differences in OVS or because the specific instance of 2.1 (running on the "davetocker" docker) has a bunch of the optional fields of OpenVSwitch table set, e.g., system_type, that are not set on the 2.5 instance. Not sure if it makes too much of a practical difference either way but thought it worth documenting. |
| Comment by Josh Hershberg [ 04/Apr/16 ] |
|
I wonder if this is related to this: |