Operating System: All
Platform: All

Hi Ashwin,

Can you please give some more details about "- using a client, make requests to read the configuration in OVSDB repeatedly.". How are you making the request? are you using RESTCONF to fetch the data from data store? Or are you using explicit library calls for that ?

@Anil:
> How are you making the request? are you using RESTCONF to fetch the data from data store? Or are you using explicit library calls for that ?

Library calls [an example -- repeated ovsdb.lib.operations.TransactionBuilder.execute calls that execute a select operation on the Port table (containing > 30 ports) using an OvsdbClient]. I believe the problem is that there are only "put" invocations on the methodContext hash-map in JsonRpcEndpoint. There is no piece of code that removes elements from the hash-map after the request is processed.

Attachment #1: Bug6157 reproducer JUnit test

Attachment Bug6157_reproducer.txt has been added with description: Bug6157 reproducer

Attachment #2: Bug6157 OutOfMemory exception after running the reproducer.

Attachment Bug6157_exception.txt has been added with description: Bug6157 OutOfMemory exception after running the reproducer

@Anil:

I have attached two files. One of them is a reproducer. It simply creates a select OVSDB transaction using ODL library calls on the OVSDB Port table, and executes it 300 times.

If you run the JUnit test after adding a large number of ports (~ 300) using "ovs-vsctl add-port <BRIDGE_NAME> <PORT_NAME>" to OVSDB, I believe you should be able to observe the OutOfMemoryError exception (second attachment). `ps aux` output shows continuous increase in the memory consumption when the test is run. I used the Beryllium-1.2.3-SR2 stable released version of ODL for running these tests.

I'd really appreciate if the fix for this Bug can be included in the forthcoming SR3 release.

The following change may be a potential workaround/fix:
-----a/library/impl/src/main/java/org/opendaylight/ovsdb/lib/jsonrpc/JsonRpcEndpoint.java
+++ b/library/impl/src/main/java/org/opendaylight/ovsdb/lib/jsonrpc/JsonRpcEndpoint.java
@@ -128,6 +128,8 @@ public class JsonRpcEndpoint

+ methodContext.remove(response.get("id").asText());
+
if (ListenableFuture.class == returnCtxt.getMethod().getReturnType()) {
TypeToken<?> retType = TypeToken.of(
returnCtxt.getMethod().getGenericReturnType())

@Anil: If you could please provide an ETA for the fix for this Bug, I'd really appreciate it. Will the fix make it to the forthcoming SR3 release?

Master : https://git.opendaylight.org/gerrit/42211
Stable/beryllium : https://git.opendaylight.org/gerrit/42113