[OVSDB-452] TransactionInvokerImpl should be daemon Created: 19/Feb/18  Updated: 19/Feb/18  Resolved: 19/Feb/18

Status: Resolved
Project: ovsdb
Component/s: Southbound.hw_vtep
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Highest
Reporter: Michael Vorburger Assignee: Unassigned
Resolution: Cannot Reproduce Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks GENIUS-114 Genius karaf shutdock deadlocks Resolved

 Description   

I suspect that this OVSDB thread could be (part of / contributing to) GENIUS-114:

"transaction-invoker-impl-0" #280 prio=5 os_prio=0 tid=0x00007fbd843ceb00 nid=0x3d76 waiting on condition [0x00007fbd45d87000]
   java.lang.Thread.State: WAITING (parking)
	at sun.misc.Unsafe.park(Native Method)
	- parking to wait for  <0x000000008a65aa70> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
	at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
	at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
	at org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl.extractCommandsFromQueue(TransactionInvokerImpl.java:188)
	at org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl.extractCommands(TransactionInvokerImpl.java:182)
	at org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl.run(TransactionInvokerImpl.java:95)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Should this not be a Thread.setDaemon(true) thread?

You could use org.opendaylight.infrautils.utils.concurrent.ThreadFactoryProvider, if you like.

Can whatever creates this be made to have clean shut-down logic which stops the thread?



 Comments   
Comment by Michael Vorburger [ 19/Feb/18 ]

Closing Serverity to Minor, because GENIUS-114 is not reliably reproduced..

Generated at Wed Feb 07 20:36:26 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.