[OVSDB-453] CSIT failing QOS test cases Created: 06/Mar/18  Updated: 09/Mar/18  Resolved: 09/Mar/18

Status: Resolved
Project: ovsdb
Component/s: CSIT
Affects Version/s: Oxygen, Fluorine
Fix Version/s: Oxygen, Fluorine

Type: Bug Priority: Highest
Reporter: Jamo Luhrsen Assignee: Vishal Thapar
Resolution: Done Votes: 0
Labels: patch_merged
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

something basic is broken causing some QOS test cases to fail.
This is happening in Oxygen and Fluorine, but not earlier. There are
multiple ERRORS that might point to the root cause. Snippets of
those below, but a full log is here. The corresponding robot
log is here

It seems that yangtools is involved somehow. I also notice that there doesn't seem to be
significant code change in the ovsdb project related to qos (just did a git diff across branches
looking for qos things). I think we've upgraded yangtools versions for Oxygen compared to
Nitrogen, so maybe the root issue is in the new yangtools.

Some ERROR snippets:

2018-03-05T07:39:38,693 | ERROR | opendaylight-cluster-data-notification-dispatcher-91 | DataTreeChangeListenerActor      | 282 - org.opendaylight.controller.sal-clustering-commons - 1.7.0.SNAPSHOT | member-1-shard-topology-config: Error notifying listener org.opendaylight.ovsdb.southbound.OvsdbDataTreeChangeListener@682a9b87
java.lang.IllegalArgumentException: Failed to map QName {} [(urn:opendaylight:params:xm2018-03-05T07:40:03,385 | ERROR | opendaylight-cluster-data-notification-dispatcher-109 | DataTreeChangeListenerActor      | 282 - org.opendaylight.controller.sal-clustering-commons - 1.7.0.SNAPSHOT | member-1-shard-topology-config: Error notifying listener org.opendaylight.ovsdb.southbound.OvsdbDataTreeChangeListener@682a9b87
java.lang.NullPointerException: null
	at org.opendaylight.ovsdb.southbound.OvsdbDataTreeChangeListener.disconnect(OvsdbDataTreeChangeListener.java:149) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]
	at org.opendaylight.ovsdb.southbound.OvsdbDataTreeChangeListener.onDataTreeChanged(OvsdbDataTreeChangeListener.java:103) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]
	at org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataTreeChangeListenerAdapter.onDataTreeChanged(BindingDOMDataTreeChangeListenerAdapter.java:41) [276:org.opendaylight.controller.sal-binding-broker-impl:1.7.0.SNAPSHOT]
	at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.dataChanged(DataTreeChangeListenerActor.java:67) [289:org.opendaylight.controller.sal-distributed-datastore:1.7.0.SNAPSHOT]
l:ns:yang:ovsdb?revision=2015-01-05)qos-entries]
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:210) [32:com.google.guava:23.3.0.jre]
	at org.opendaylight.yangtools.yang.data.util.AbstractNamespaceCodec.appendQName(AbstractNamespaceCodec.java:48) [496:org.opendaylight.yangtools.yang-data-util:2.0.1]
	at org.opendaylight.yangtools.yang.data.util.AbstractNamespaceCodec.appendQName(AbstractNamespaceCodec.java:66) [496:org.opendaylight.yangtools.yang-data-util:2.0.1]
	at org.opendaylight.yangtools.yang.data.util.AbstractStringInstanceIdentifierCodec.serialize(AbstractStringInstanceIdentifierCodec.java:58) [496:org.opendaylight.yangtools.yang-data-util:2.0.1]
	at org.opendaylight.ovsdb.southbound.InstanceIdentifierCodec.serialize(InstanceIdentifierCodec.java:66) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]
	at org.opendaylight.ovsdb.southbound.ovsdb.transact.QosUpdateCommand.execute(QosUpdateCommand.java:102) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]
	at org.opendaylight.ovsdb.southbound.ovsdb.transact.QosUpdateCommand.execute(QosUpdateCommand.java:58) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]
2018-03-05T07:39:38,826 | ERROR | opendaylight-cluster-data-notification-dispatcher-99 | DataTreeChangeListenerActor      | 282 - org.opendaylight.controller.sal-clustering-commons - 1.7.0.SNAPSHOT | member-1-shard-topology-config: Error notifying listener org.opendaylight.ovsdb.southbound.OvsdbDataTreeChangeListener@682a9b87
java.lang.IllegalArgumentException: Failed to map QName {} [(urn:opendaylight:params:xml:ns:yang:ovsdb?revision=2015-01-05)queues]
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:210) [32:com.google.guava:23.3.0.jre]
	at org.opendaylight.yangtools.yang.data.util.AbstractNamespaceCodec.appendQName(AbstractNamespaceCodec.java:48) [496:org.opendaylight.yangtools.yang-data-util:2.0.1]
	at org.opendaylight.yangtools.yang.data.util.AbstractNamespaceCodec.appendQName(AbstractNamespaceCodec.java:66) [496:org.opendaylight.yangtools.yang-data-util:2.0.1]
	at org.opendaylight.yangtools.yang.data.util.AbstractStringInstanceIdentifierCodec.serialize(AbstractStringInstanceIdentifierCodec.java:58) [496:org.opendaylight.yangtools.yang-data-util:2.0.1]
	at org.opendaylight.ovsdb.southbound.InstanceIdentifierCodec.serialize(InstanceIdentifierCodec.java:66) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]
	at org.opendaylight.ovsdb.southbound.ovsdb.transact.QueueUpdateCommand.execute(QueueUpdateCommand.java:92) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]
	at org.opendaylight.ovsdb.southbound.ovsdb.transact.QueueUpdateCommand.execute(QueueUpdateCommand.java:57) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]
2018-03-05T07:40:03,385 | ERROR | opendaylight-cluster-data-notification-dispatcher-109 | DataTreeChangeListenerActor      | 282 - org.opendaylight.controller.sal-clustering-commons - 1.7.0.SNAPSHOT | member-1-shard-topology-config: Error notifying listener org.opendaylight.ovsdb.southbound.OvsdbDataTreeChangeListener@682a9b87
java.lang.NullPointerException: null
	at org.opendaylight.ovsdb.southbound.OvsdbDataTreeChangeListener.disconnect(OvsdbDataTreeChangeListener.java:149) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]
	at org.opendaylight.ovsdb.southbound.OvsdbDataTreeChangeListener.onDataTreeChanged(OvsdbDataTreeChangeListener.java:103) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]
	at org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataTreeChangeListenerAdapter.onDataTreeChanged(BindingDOMDataTreeChangeListenerAdapter.java:41) [276:org.opendaylight.controller.sal-binding-broker-impl:1.7.0.SNAPSHOT]
	at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.dataChanged(DataTreeChangeListenerActor.java:67) [289:org.opendaylight.controller.sal-distributed-datastore:1.7.0.SNAPSHOT]
2018-03-05T07:42:29,110 | ERROR | opendaylight-cluster-data-notification-dispatcher-109 | DataTreeChangeListenerActor      | 282 - org.opendaylight.controller.sal-clustering-commons - 1.7.0.SNAPSHOT | member-1-shard-topology-config: Error notifying listener org.opendaylight.ovsdb.southbound.OvsdbDataTreeChangeListener@682a9b87
java.lang.NullPointerException: null
	at org.opendaylight.ovsdb.southbound.SouthboundMapper.suppressLocalIpPort(SouthboundMapper.java:381) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]
	at org.opendaylight.ovsdb.southbound.OvsdbConnectionManager.getInstanceIdentifier(OvsdbConnectionManager.java:279) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]
	at org.opendaylight.ovsdb.southbound.OvsdbDataTreeChangeListener.disconnect(OvsdbDataTreeChangeListener.java:145) [456:org.opendaylight.ovsdb.southbound-impl:1.6.0.SNAPSHOT]

 Comments   
Comment by Vishal Thapar [ 06/Mar/18 ]

Mail list discussing the issue: https://lists.opendaylight.org/pipermail/ovsdb-dev/2018-March/004585.html

Comment by Daniel Farrell [ 08/Mar/18 ]

Who's working on this? thapar? We need to get this resolved ASAP to unblock the imminent Oxygen release.

Comment by Daniel Farrell [ 08/Mar/18 ]

https://git.opendaylight.org/gerrit/#/c/67191/3/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/InstanceIdentifierCodec.java@55

Comment by Tom Pantelis [ 08/Mar/18 ]

Submitted https://git.opendaylight.org/gerrit/#/c/69290/

Comment by Jamo Luhrsen [ 08/Mar/18 ]

Submitted https://git.opendaylight.org/gerrit/#/c/69290/

I will run the resulting distribution from the distro-check job through CSIT and report back here.

Comment by Tom Pantelis [ 08/Mar/18 ]

Ok - thanks. I just submitted a second patch set - the UT needed to be updated.

Comment by Sam Hague [ 09/Mar/18 ]

https://git.opendaylight.org/gerrit/69294

Generated at Wed Feb 07 20:36:26 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.