[OVSDB-467] Neon-MRI: Bump odlparent, yangtools, mdsal Created: 04/Sep/18  Updated: 26/Oct/18  Due: 27/Sep/18  Resolved: 26/Oct/18

Status: Resolved
Project: ovsdb
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Medium
Reporter: Michael Vorburger Assignee: Vishal Thapar
Resolution: Done Votes: 0
Labels: neon-mri
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks GENIUS-210 Neon-MRI: Bump odlparent, yangtools, ... Resolved
blocks NEUTRON-197 Neon-MRI: Bump odlparent, yangtools, ... Resolved
blocks TSC-132 Neon MRI Integration Window Resolved
is blocked by ODLPARENT-163 Release odlparent 4.0.1 for Neon-MRI:... Resolved

 Description   

ovsdb part of https://git.opendaylight.org/gerrit/#/q/topic:neon-mri ...



 Comments   
Comment by Michael Vorburger [ 17/Sep/18 ]

Good people of OVSDB, this issue is a blocking required dependency in order for me to make progress in NEUTRON-197; which now fails with the following error, which most likely is due to me not yet having an ovsdb with version bumps available:

[INFO] --- maven-surefire-plugin:2.18.1:test (default) @ odl-neutron-hostconfig-ovs ---
[INFO] Surefire report directory: /home/vorburger/dev/ODL/git/neutron/features/production/odl-neutron-hostconfig-ovs/target/surefire-reports

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.opendaylight.odlparent.featuretest.SingleFeatureTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 60.151 sec <<< FAILURE! - in org.opendaylight.odlparent.featuretest.SingleFeatureTest
installFeatureCatchAndLog(org.opendaylight.odlparent.featuretest.SingleFeatureTest)[repoUrl: file:/home/vorburger/dev/ODL/git/neutron/features/production/odl-neutron-hostconfig-ovs/target/feature/feature.xml, Feature: odl-neutron-hostconfig-ovs 0.12.0.SNAPSHOT]  Time elapsed: 57.007 sec  <<< ERROR!
org.apache.felix.resolver.reason.ReasonException: Unable to resolve org.opendaylight.mdsal.model.ietf-inet-types-2013-07-15/1.6.0.SNAPSHOT: missing requirement [org.opendaylight.mdsal.model.ietf-inet-types-2013-07-15/1.6.0.SNAPSHOT] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.opendaylight.yangtools.yang.binding)(version>=0.14.0)(!(version>=1.0.0)))"
	at org.apache.felix.resolver.Candidates$MissingRequirementError.toException(Candidates.java:1343)
(...)

Results :

Tests in error: 
  Unable to resolve org.opendaylight.mdsal.model.ietf-inet-types-2013-07-15/1.6.0.SNAPSHOT: missing requirement [org.opendaylight.mdsal.model.ietf-inet-types-2013-07-15/1.6.0.SNAPSHOT] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.opendaylight.yangtools.yang.binding)(version>=0.14.0)(!(version>=1.0.0)))"

thapar seeing this issue assigned to you, can you confirm that you are planning to work on this? This week? 

FYI https://wiki.opendaylight.org/view/Neon_platform_upgrade has step-by-step instructions ...

Comment by Vishal Thapar [ 20/Sep/18 ]

Currently busy with travel and slides stuff, should be able to squeeze out some time during transit.

Comment by Vishal Thapar [ 24/Sep/18 ]

OVSDB is compiling locally now.
Genius failing on OpenFlowPlugin dependency now

Comment by Michael Vorburger [ 24/Sep/18 ]

> OVSDB is compiling locally now.

Thanks! I just pulled to (to continue with NEUTRON-197), but:

[INFO] BugInstance size is 1
 [INFO] Error size is 0
 [INFO] Total bugs: 1
 [INFO] To make log readable, log format ({}:{}) should contain non-sign character. [org.opendaylight.ovsdb.lib.schema.GenericTableSchema] At GenericTableSchema.java:[line 43] SLF4J_SIGN_ONLY_FORMAT}}
Comment by Vishal Thapar [ 24/Sep/18 ]

I thought we were trying to run locally with skip tests? Running with findbugs only now, will address any that I find.

Comment by Michael Vorburger [ 24/Sep/18 ]

> I thought we were trying to run locally with skip tests?

Only for projects you depend on (and just to be faster, and because those tests are "not your problem" when you work on another project), but for the project you migrate itself a normal full build with FindBugs and all tests and SFT and everything has to pass.

> Running with findbugs only now, will address any that I find.

https://git.opendaylight.org/gerrit/#/c/76389/5..6 fixes a bunch onf stuff.

Comment by Michael Vorburger [ 24/Sep/18 ]

thapar but does SFT already pass for you on ovsdb? It still fails for me because odl-ovsdb-hwvtepsouthbound-rest still wants odl-jackson-2.8 (although you already changed its dependency to odl-jackson-2.9, must be a transitive dependency...)

FYI even if you skip unit tests and PockerMock test failures, we have to get SFT to pass before you can work on genius.

Comment by Michael Vorburger [ 24/Sep/18 ]

Please ignore re. odl-jackson-2.8 - I just did not install the latest netconf patch.

Comment by Vishal Thapar [ 24/Sep/18 ]

FYI: http://www.technicaladvices.com/2017/04/09/mockito-2-x-over-powermock-migration-tips-and-tricks-top-ten/

Comment by Vishal Thapar [ 26/Sep/18 ]

Even with updated mockito, basic mock() seems to give errors:

OvsdbDataTreeChangeListenerTest.<init>:38 » IllegalState Could not initialize ...
OvsdbMonitorCallbackTest.<init>:33 » IllegalState Could not initialize plugin:...
OvsdbMonitorCallbackTest.<init>:33 » IllegalState Could not initialize plugin:...

Comment by Stephen Kitt [ 05/Oct/18 ]

This is now complete, the linked patch builds with the other Neon MRI bumps.

Generated at Wed Feb 07 20:36:28 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.