[OVSDB-470] Excessive toString in SouthboundUtils.isBridgeOnOvsdbNode() Created: 12/Nov/18 Updated: 19/Dec/18 Resolved: 19/Dec/18 |
|
| Status: | Resolved |
| Project: | ovsdb |
| Component/s: | Southbound.Open_vSwitch |
| Affects Version/s: | Oxygen-SR3 |
| Fix Version/s: | Neon |
| Type: | Bug | Priority: | High |
| Reporter: | Michael Vorburger | Assignee: | Michael Vorburger |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
I'm looking at a Java Flight Recording obtained from (internal) scale lab testing, and see extensive "TLAB Allocations" due to what appears to be a clear mistake causing Excessive toString in SouthboundUtils.isBridgeOnOvsdbNode() : char[] java.util.Arrays.copyOf(char[], int) 19544 void java.lang.AbstractStringBuilder.ensureCapacityInternal(int) 19544 AbstractStringBuilder java.lang.AbstractStringBuilder.append(char) 12292 StringBuilder java.lang.StringBuilder.append(char) 12292 String com.google.common.base.MoreObjects$ToStringHelper.toString() 11244 String org.opendaylight.yangtools.yang.binding.InstanceIdentifier.toString() 11244 boolean org.opendaylight.ovsdb.utils.southbound.utils.SouthboundUtils.isBridgeOnOvsdbNode(Node, String) 11244 Boolean org.opendaylight.netvirt.elan.internal.ElanBridgeManager.isBridgeOnOvsdbNode(Node, String) 11244 void org.opendaylight.netvirt.elan.internal.ElanOvsdbNodeListener.update(InstanceIdentifier, Node, Node) 11244 void org.opendaylight.netvirt.elan.internal.ElanOvsdbNodeListener.update(InstanceIdentifier, DataObject, DataObject) 11244 void org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase$DataTreeChangeHandler.run() 11244 void java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor$Worker) 11244 void java.util.concurrent.ThreadPoolExecutor$Worker.run() 11244 void java.lang.Thread.run() 11244 |
| Comments |
| Comment by Stephen Kitt [ 13/Nov/18 ] |
|
Could you clarify what the clear mistake is? |
| Comment by Michael Vorburger [ 13/Nov/18 ] |
|
c/77719 should help to avoid excessive toString() ? |
| Comment by Michael Vorburger [ 10/Dec/18 ] |
|
My c/77719 went in on Thursday; skitt's c/77721 still needs a rebase, this this issue is done for Neon, and could be cherry-picked. |
| Comment by Michael Vorburger [ 19/Dec/18 ] |
|
It's in Neon now, let's close this, for now; we can cherry-pick to Fluorine later, if needed. |