[OVSDB-495] Eliminate ControllerMdsalUtils et al. Created: 01/May/20 Updated: 12/Jan/21 Resolved: 26/Jun/20 |
|
| Status: | Resolved |
| Project: | ovsdb |
| Component/s: | Commons |
| Affects Version/s: | None |
| Fix Version/s: | unspecified |
| Type: | Bug | Priority: | High |
| Reporter: | Robert Varga | Assignee: | Chetan Arakere Gowdru |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0 minutes | ||
| Time Spent: | 1 day | ||
| Original Estimate: | Not Specified | ||
| Description |
|
With the MD-SAL migration done, there are now two almost identical classes, as reported by CPD: [INFO] --- maven-pmd-plugin:3.13.0:cpd-check (cpd) @ utils.mdsal-utils --- [INFO] PMD version: 6.21.0 [INFO] CPD Failure: Found 159 lines of duplicated code at locations: [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/ControllerNotifyingDataChangeListener.java line 70 [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/NotifyingDataChangeListener.java line 68 [INFO] CPD Failure: Found 56 lines of duplicated code at locations: [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/ControllerMdsalUtils.java line 100 [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/MdsalUtils.java line 98 [INFO] CPD Failure: Found 83 lines of duplicated code at locations: [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/ControllerMdsalUtilsAsync.java line 131 [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/MdsalUtilsAsync.java line 130 [INFO] CPD Failure: Found 14 lines of duplicated code at locations: [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/ControllerNotifyingDataChangeListener.java line 34 [INFO] /home/nite/odl/ovsdb/utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/NotifyingDataChangeListener.java line 33 [INFO] You have 4 CPD duplications. For more details see: /home/nite/odl/ovsdb/utils/mdsal-utils/target/cpd.xml the intent was the have the ones not starting with Controller to supersede the Controller classes and remove them. This needs to be rectified, as it is a maintenance burden an confuses downstreams as to which class to use. |