[RELENG-12] Allow JDK8 to be enabled on select branches in auto-jjb scripts Created: 05/May/15  Updated: 19/Oct/17  Resolved: 07/May/15

Status: Resolved
Project: releng
Component/s: Jenkins Job Builder
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Andrew Grimberg Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 3122

 Description   

We need a way to enable JDK8 on projects that have branches that can't do JDK8. Otherwise we end up with projects disabling the auto job management for any branch that they want to do JDK8 on.

For instance: https://git.opendaylight.org/gerrit/#/c/19329/



 Comments   
Comment by Thanh Ha (zxiiro) [ 05/May/15 ]

Created an initial blank commit to describe my plan to add support for this feature. https://git.opendaylight.org/gerrit/19644

Heavy modifications will be needed in jjb-init-project and jjb-autoupdate-project script to support this more complex configuration format.

We'll need to refactor the parsing of the CFG file into jjb-init-project so that it is capable of reading the new configuration for BRANCHES. Due to this configuration being more complex we'll also lose support for setting the "-b" branches argument in init-project, or keep it simple but document that it is not possible to set the JDK this way.

Comment by Andrew Grimberg [ 05/May/15 ]

Maybe the configuration file should be switched from a basic key value setup to a yaml?

That way we won't have to deal with reformatting different parts of it later, just handling the keys in different ways.

Comment by Thanh Ha (zxiiro) [ 05/May/15 ]

(In reply to Andrew Grimberg from comment #2)
> Maybe the configuration file should be switched from a basic key value setup
> to a yaml?
>
> That way we won't have to deal with reformatting different parts of it
> later, just handling the keys in different ways.

It's actually already YAML format. We just happened to use it as a basic key-value store but the code that reads this file is actually a call to "yaml.load(stream)".

Comment by Andrew Grimberg [ 05/May/15 ]

(In reply to Thanh Ha from comment #3)
> (In reply to Andrew Grimberg from comment #2)
> > Maybe the configuration file should be switched from a basic key value setup
> > to a yaml?
> >
> > That way we won't have to deal with reformatting different parts of it
> > later, just handling the keys in different ways.
>
> It's actually already YAML format. We just happened to use it as a basic
> key-value store but the code that reads this file is actually a call to
> "yaml.load(stream)".

Ah silly me. That's what I get for not actually looking at how we load that file Though I think I remember talking about it when you set the extension to .cfg instead of .yaml since a .yaml would have caused jjb to pick up the file during processing.

Generated at Wed Feb 07 20:37:16 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.