[RELENG-36] Distribution-check should be run on trivial rebases and no-code changes Created: 11/Oct/16  Updated: 03/May/18  Resolved: 19/Nov/16

Status: Resolved
Project: releng
Component/s: Jenkins Job Builder
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Alexis de Talhouët Assignee: Vratko Polak
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 6926

 Description   

... because distribution-check allows you to spot whenever you're breaking a dependency or something of the sort.

The reason I'm opening this bug is because I faced the following:

  • PatchXYZ in Genius removes an artifact
  • Netvirt is actually using the artifact the Genius patch PatchXYZ wants to remove
  • PatchXYZ will fail to build because distribution-check will complain of a missing dependency (obviously the one build PatchXYZ removes)
  • Update the commit message --> only the verify job gets triggered, and jenkins will successfully verified. But distribution-check will not run, thus the patch will get verified, although it should have failed.

Merging such a patch would break autorelease. I think to avoid this, we should always run distribution-check.

See https://git.opendaylight.org/gerrit/#/c/46689/ for reference.

 Comments   
Comment by Alexis de Talhouët [ 11/Oct/16 ]

https://git.opendaylight.org/gerrit/#/c/46792/

Comment by Vratko Polak [ 12/Oct/16 ]

> I think to avoid this, we should always run distribution-check.

No, we should skip triggering the verify job instead.

After the implemented fix we still have a similar situation related to validate-autorelease job. If only validate-autorelease job is failing and you update the commit message, verify and distribution-check are triggered and you get a false verified+1.

I have a better fix [0] waiting for review for some time, let me rebase that.

[0] https://git.opendaylight.org/gerrit/46043

Comment by Alexis de Talhouët [ 12/Oct/16 ]

Vratko, thanks for those input and sorry this has move so fast yesterday. I'm assigning the BUG to you. Can you please update your patch to reflect that BUG please.
Thanks

Generated at Wed Feb 07 20:37:20 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.