[RELENG-37] CONTROLLER Carbon Autorelease Build Failures Created: 27/Oct/16  Updated: 19/Oct/17  Resolved: 31/Oct/16

Status: Resolved
Project: releng
Component/s: Autorelease
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: A H Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 7053

 Description   

There are Carbon Autorelease Build Failures in sal-clustering-commons.

https://jenkins.opendaylight.org/releng/view/autorelease/job/autorelease-release-carbon/41/consoleFull

00:48:33 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile) on project sal-clustering-commons: Compilation failure: Compilation failure:
00:48:33 [ERROR] /w/workspace/autorelease-release-carbon/controller/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/AbstractNormalizedNodeDataOutput.java:[11,39] package edu.umd.cs.findbugs.annotations does not exist
00:48:33 [ERROR] /w/workspace/autorelease-release-carbon/controller/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/AbstractNormalizedNodeDataOutput.java:[365,6] cannot find symbol
00:48:33 [ERROR] symbol: class SuppressFBWarnings
00:48:33 [ERROR] location: class org.opendaylight.controller.cluster.datastore.node.utils.stream.AbstractNormalizedNodeDataOutput



 Comments   
Comment by Vratko Polak [ 29/Oct/16 ]

The reference to the class in question was introduced here:
https://git.opendaylight.org/gerrit/#/c/46919/4/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/datastore/node/utils/stream/AbstractNormalizedNodeDataOutput.java

Controller merge jobs download the required jar and compilation passes without any issues:
[INFO] Downloading: https://nexus.opendaylight.org/content/repositories/public/com/google/code/findbugs/annotations/3.0.0/annotations-3.0.0.jar

I have no idea why the autorelease job never attempts such a download, thus ignoring odlparent:odlparent declaration:
https://git.opendaylight.org/gerrit/#/c/47357/1/odlparent/pom.xml@1244

Attempted workaround: https://git.opendaylight.org/gerrit/47751

But the real issue is somewhere else: autorelease, odlparent:odlparent, or perhaps controller:commons.opendaylight.
So in future there may appear similar Bugs, which also break autorelease only, without any warnings from verify or merge jobs.

Comment by Vratko Polak [ 30/Oct/16 ]

So it was the known issue of autorelease not updating submodules (in this case odlparent commit is from before 47357 was merged).

Fix for the current submodule commits: https://git.opendaylight.org/gerrit/47755

Maybe we need a job to perform "git checkout

{branch}

" in each submodule (and push the new commit to autorelease master) before triggering autorelease-release-

{stream}

.

Comment by Robert Varga [ 30/Oct/16 ]

I think this may have something to do with:

Downloading: http://oss.sonatype.org/content/repositories/snapshots/org/opendaylight/odlparent/findbugs/1.8.0-SNAPSHOT/maven-metadata.xml
Downloaded: https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/odlparent/findbugs/1.8.0-SNAPSHOT/maven-metadata.xml (784 B at 0.6 KB/sec)
[WARNING] Could not transfer metadata org.opendaylight.odlparent:findbugs:1.8.0-SNAPSHOT/maven-metadata.xml from/to codehaus-snapshots (http://nexus.codehaus.org/snapshots/): nexus.codehaus.org: No address associated with hostname
[WARNING] Failure to transfer org.opendaylight.odlparent:findbugs:1.8.0-SNAPSHOT/maven-metadata.xml from http://nexus.codehaus.org/snapshots/ was cached in the local repository, resolution will not be reattempted until the update interval of codehaus-snapshots has elapsed or updates are forced. Original error: Could not transfer metadata org.opendaylight.odlparent:findbugs:1.8.0-SNAPSHOT/maven-metadata.xml from/to codehaus-snapshots (http://nexus.codehaus.org/snapshots/): nexus.codehaus.org: No address associated with hostname

Which points to findbugs not having proper declaration of scm/distributionManagement or similar.

Comment by Robert Varga [ 30/Oct/16 ]

https://git.opendaylight.org/gerrit/47759

Another thing that occurs to me is the annotations version – we have 3.0.0 declared, but the plugin uses 3.0.1: http://gleclaire.github.io/findbugs-maven-plugin/dependency-updates-report.html

https://git.opendaylight.org/gerrit/47760 should address that.

Comment by Stephen Kitt [ 31/Oct/16 ]

autorelease is lagging behind odlparent (again):

$ git submodule status odlparent
ff5ec3d1679aed8315cac5ba159c14118f08e62c odlparent (odlparent-aggregator-1.7.0-104-gff5ec3d)

which is https://git.opendaylight.org/gerrit/47185

Comment by Thanh Ha (zxiiro) [ 31/Oct/16 ]

Updated and merged Vratko's patch for autorelease. Thanks everyone.

Generated at Wed Feb 07 20:37:20 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.