[SFC-101] move access-lists-state from ietf-acl.yang Created: 02/Oct/15  Updated: 29/May/18  Resolved: 29/May/18

Status: Verified
Project: sfc
Component/s: General
Affects Version/s: unspecified
Fix Version/s: Carbon

Type: Bug
Reporter: Ruijing Guo Assignee: Ruijing Guo
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 4401

 Description   

We may move access-lists-state from ietf-acl.yang to service-function-acl.yang



 Comments   
Comment by Ruijing Guo [ 02/Oct/15 ]

On 9/28/15, 7:32 PM, "Guo, Ruijing" <ruijing.guo@intel.com> wrote:

>Hi, Brady, Reinaldo,
>
>I start to update IETF ACL Yang to
>https://tools.ietf.org/html/draft-ietf-netmod-acl-model-03.
>
>It is tracked by https://bugs.opendaylight.org/show_bug.cgi?id=4362.
>
>The change is big so that we need to make sure everyone is ok to update
>before we start.
>
>1) IETF ACL Yang is draft v3. ( we assume it is stable and not too much
>change before official IETF)
>https://tools.ietf.org/html/draft-ietf-netmod-acl-model-03

[RP] It will certainly change. Another possibility is to use classifier model specific for services chaining that is under our control. Attached is a model that was recently proposed by our router folks.

>
>2) how to port
>
>a. delete yang
>sfc-model/src/main/yang/packet-fields.yang
>sfc-model/src/main/yang/ietf-acl.yang
>b. add yang
>sfc-model/src/main/yang/ietf-access-control-list.yang
>sfc-model/src/main/yang/ietf-packet-fields.yang
>
>c. update all java files (much change)
>
>3) container access-lists-state is missing in IETF ACL Yang. I will
>port access-lists-state to service-function-acl.yang:

[RP] I¹m with Keith. Let¹s use the new model as it is. It has OPER containers already.

>
>--- a/sfc-model/src/main/yang/service-function-acl.yang
>+++ b/sfc-model/src/main/yang/service-function-acl.yang
>
>+
>+ container access-lists-state {
>+ description
>+ "This container hold operational state for all access lists";
>+ config false;
>+
>+ list access-list-state {
>+ description
>+ "This list holds operational data for all access lists
>+ in the domain";
>+ key "acl-name";
>+ leaf acl-name

{ >+ type string; >+ description >+ "The name of the acl"; >+ }

>+ list acl-service-function-classifier {
>+ key "name";
>+ leaf name

{ >+ type string; >+ description >+ "The name of the classifier"; >+ }

>+ description
>+ "A list of all classifiers that use rules from this access list";
>+ }
>+ }
>+ }
> }

Comment by Keith Burns [ 12/Oct/15 ]

Ruijing, it seems like you are working on this, so hope you don't mind me assigning it to you.

If thats ok, can you update the ODL SR Milestone too?

Comment by Brady Johnson [ 29/May/18 ]

This has been completed, as can be seen by this git blame command:

$ git blame service-function-acl.yang

8f3279f4a (Ruijing Guo 2016-01-26 00:31:12 +0000 45) container access-lists-state {

Generated at Wed Feb 07 20:38:38 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.