[SFC-118] RPCs hiding heuristics using Strings Created: 18/Oct/15 Updated: 18/Oct/15 |
|
| Status: | Confirmed |
| Project: | sfc |
| Component/s: | General |
| Affects Version/s: | unspecified |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Keith Burns | Assignee: | Keith Burns |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 4495 |
| Description |
|
The whole issue of RPCs in SFC needs at somepoint to be addressed. During introduction of Types (RspName, SfName etc) during a patch, I found that many RPCs are using the fact that things used to be Strings to allow various fields to be used interchangeably. This isn't always WRONG but it does embed some implicit heuristics as to what various things mean (ie why is an RSPNAME and SFPNAME able to be used interchangeably? If so then perhaps they should be the same defined type, if not then ... etc.. you get the idea. So rather than decorating the code with long comments or obscure comments, as I refactor for typedefs I am going to put a TODO with this BugID so we can track them. |
| Comments |
| Comment by Keith Burns [ 18/Oct/15 ] |
|
This isn't limited to RPCs, but also general read methods etc where the fact something like an rspName was a string could be used interchangeably with something expecting an sfpName.. .which was also a string, hence it worked, but hid the heuristic. |