[SFC-144] Wrong run-time check for variable value Created: 12/May/16  Updated: 19/Oct/17  Resolved: 07/Jun/16

Status: Resolved
Project: sfc
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Javier Arauz Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 5879
Priority: Lowest

 Description   

In file SfcScfOfProcessor.java starting at line 135:

String ruleName = ace.getRuleName();
if (ruleName == null) {
LOG.error("createdServiceFunctionClassifier: ruleName is null\n");
continue;
}

....

// Action
Actions actions = ace.getActions();
if (ruleName == null) {
LOG.error("createdServiceFunctionClassifier: action is null\n");
continue;
}

The second check on ruleName seems a copy&paste duplicate, it should be checking variable actions instead.

 Comments   
Comment by Suvitha Balu [ 23/May/16 ]

The bug is fixed as part of https://bugs.opendaylight.org/show_bug.cgi?id=5871.

Verified the latest master code and the actions null check updated.

So closing the bug.

Comment by Suvitha Balu [ 24/May/16 ]

The issue is fixed for one check as mentioned in bug line approx. 135 (createdServiceFunctionClassifier method )and not in other case deletedServiceFunctionClassifier method (aprox line 284). So opening the bug .

The additional fix pushed for review : https://git.opendaylight.org/gerrit/#/c/39301/

Comment by Suvitha Balu [ 07/Jun/16 ]

Patch merged.

Generated at Wed Feb 07 20:38:45 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.