[SFC-146] Memory leak + some flows left behind after cleanup when creating + deleting RSPs Created: 26/May/16 Updated: 21/Sep/16 Resolved: 21/Sep/16 |
|
| Status: | Resolved |
| Project: | sfc |
| Component/s: | General |
| Affects Version/s: | unspecified |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Diego Granados | Assignee: | Miguel Duarte de Mora Barroso |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 5969 |
| Priority: | Low |
| Description |
|
On the test, we're adding 2 RSPs: The sequence of actions leading to this bug being reproduced: 1: Create RSP1 2: Create RSP2. 3: Delete RSP2. The problem is in the "clearSffIfNoRspExists" method in SfcL2FlowWriterImpl class. It only deletes initialization flows when ALL RSPs are deleted; but this is too coarse: initialization flows for each SFF should be accounted separately, so when no RSPs for the SFF remain, initialization flows for the SFF are removed. Just for your info, I plan to submit a renderer patch in the following days (it introduces transactional flow write/deletion for all flows when the RSP is created/deleted, which can be seen also as a fix for https://bugs.opendaylight.org/show_bug.cgi?id=4806), which includes two new unit tests currently nonpassing because of this bug. The tests check flow creation + internal state for the Create:RSP1->Create:RSP2->Delete:RSP2->Delete:RSP1 and Create:RSP1->Create:RSP2->Delete:RSP1->Delete:RSP2 sequences |
| Comments |
| Comment by Miguel Duarte de Mora Barroso [ 13/Sep/16 ] |