[SFC-209] inter-project dependencies are not expressed correctly in feature definitions Created: 13/Feb/18  Updated: 23/Feb/18  Resolved: 23/Feb/18

Status: Resolved
Project: sfc
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Highest
Reporter: Faseela K Assignee: Brady Johnson
Resolution: Cannot Reproduce Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

As per

https://lists.opendaylight.org/pipermail/release/2018-January/013604.html

https://lists.opendaylight.org/pipermail/release/2017-September/012356.html

sfc inter-project dependencies are not expressed correctly in feature definitions, as downstream projects are packaging their ODL upstream's bundles directly in their features, rather than properly depending on upstream's features.

Please read the above mails to get full understanding of the issue, and please fix the same in your project. 

You can close the Jira if you have already taken care of the same.

 Comments   
Comment by Brady Johnson [ 23/Feb/18 ]

I looked into this, and as of February 23rd its no longer a problem in SFC.

To reach this conclusion, I did the following:

  1. Build the SFC Oxygen code
  2. cd sfc/karaf/target/assembly/system/org/opendaylight
    • This directory contains the features repo needed for the SFC distro, including ALL of the SFC features.
    • For the sake of this study, I only focused on the SFC features
  3. We can get all of the bundles created by SFC with this command:
    • find sfc -name *features.xml | xargs fgrep '<bundle>'
  4. We can get all of the non-SFC bundles with this command:
    • find sfc -name *features.xml | xargs fgrep '<bundle>' | fgrep -v '<bundle>mvn:org.opendaylight.sfc'

The following are the non-SFC bundles that get created by the SFC features:
(as you can see, SFC doesnt create bundles for anything ODL)

 

$ find sfc -name \*features.xml | xargs fgrep '<bundle>' | fgrep -v '<bundle>mvn:org.opendaylight.sfc'
sfc/odl-sfc-scf-openflow/0.7.0-SNAPSHOT/odl-sfc-scf-openflow-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:com.fasterxml.uuid/java-uuid-generator/3.1.3</bundle>
sfc/odl-sfc-scf-openflow/0.7.0-SNAPSHOT/odl-sfc-scf-openflow-0.7.0-SNAPSHOT-features.xml: <bundle>wrap:mvn:log4j/log4j/1.2.13</bundle>
sfc/odl-sfc-vnfm-tacker/0.7.0-SNAPSHOT/odl-sfc-vnfm-tacker-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:com.fasterxml.jackson.core/jackson-annotations/2.8.9</bundle>
sfc/odl-sfc-vnfm-tacker/0.7.0-SNAPSHOT/odl-sfc-vnfm-tacker-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:com.sun.jersey/jersey-client/1.17</bundle>
sfc/odl-sfc-ui/0.7.0-SNAPSHOT/odl-sfc-ui-0.7.0-SNAPSHOT-features.xml: <bundle>wrap:mvn:javax.inject/javax.inject/1</bundle>
sfc/odl-sfc-vpp-renderer/0.7.0-SNAPSHOT/odl-sfc-vpp-renderer-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:com.fasterxml.uuid/java-uuid-generator/3.1.3</bundle>
sfc/odl-sfc-vpp-renderer/0.7.0-SNAPSHOT/odl-sfc-vpp-renderer-0.7.0-SNAPSHOT-features.xml: <bundle>wrap:mvn:log4j/log4j/1.2.13</bundle>
sfc/odl-sfc-openflow-renderer/0.7.0-SNAPSHOT/odl-sfc-openflow-renderer-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:com.fasterxml.uuid/java-uuid-generator/3.1.3</bundle>
sfc/odl-sfc-openflow-renderer/0.7.0-SNAPSHOT/odl-sfc-openflow-renderer-0.7.0-SNAPSHOT-features.xml: <bundle>wrap:mvn:log4j/log4j/1.2.13</bundle>
sfc/odl-sfc-scf-vpp/0.7.0-SNAPSHOT/odl-sfc-scf-vpp-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:com.fasterxml.uuid/java-uuid-generator/3.1.3</bundle>
sfc/odl-sfc-scf-vpp/0.7.0-SNAPSHOT/odl-sfc-scf-vpp-0.7.0-SNAPSHOT-features.xml: <bundle>wrap:mvn:log4j/log4j/1.2.13</bundle>
sfc/odl-sfc-model/0.7.0-SNAPSHOT/odl-sfc-model-0.7.0-SNAPSHOT-features.xml: <bundle>wrap:mvn:javax.inject/javax.inject/1</bundle>
sfc/odl-sfc-statistics/0.7.0-SNAPSHOT/odl-sfc-statistics-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:com.fasterxml.uuid/java-uuid-generator/3.1.3</bundle>
sfc/odl-sfc-statistics/0.7.0-SNAPSHOT/odl-sfc-statistics-0.7.0-SNAPSHOT-features.xml: <bundle>wrap:mvn:log4j/log4j/1.2.13</bundle>

 

Comment by Faseela K [ 23/Feb/18 ]

This is the snippet from the mail, and if these are already fixed, feel free to close the JIRA:

 

sfc/odl-sfc-scf-vpp/0.7.0-SNAPSHOT/odl-sfc-scf-vpp-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:org.opendaylight.controller/sal-common-util/1.7.0-SNAPSHOT</bundle>

>

sfc/odl-sfc-scf-vpp/0.7.0-SNAPSHOT/odl-sfc-scf-vpp-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:org.opendaylight.controller/sal-common-impl/1.7.0-SNAPSHOT</bundle>

>

sfc/odl-sfc-scf-vpp/0.7.0-SNAPSHOT/odl-sfc-scf-vpp-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:org.opendaylight.controller/sal-common-api/1.7.0-SNAPSHOT</bundle>

>

sfc/odl-sfc-vpp-renderer/0.7.0-SNAPSHOT/odl-sfc-vpp-renderer-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:org.opendaylight.controller/sal-common-util/1.7.0-SNAPSHOT</bundle>

>

sfc/odl-sfc-vpp-renderer/0.7.0-SNAPSHOT/odl-sfc-vpp-renderer-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:org.opendaylight.controller/sal-common-impl/1.7.0-SNAPSHOT</bundle>

>

sfc/odl-sfc-vpp-renderer/0.7.0-SNAPSHOT/odl-sfc-vpp-renderer-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:org.opendaylight.controller/sal-common-api/1.7.0-SNAPSHOT</bundle>

>

sfc/odl-sfc-pot-netconf-renderer/0.7.0-SNAPSHOT/odl-sfc-pot-netconf-renderer-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:org.opendaylight.controller/sal-common-util/1.7.0-SNAPSHOT</bundle>

>

sfc/odl-sfc-pot-netconf-renderer/0.7.0-SNAPSHOT/odl-sfc-pot-netconf-renderer-0.7.0-SNAPSHOT-features.xml: <bundle>mvn:org.opendaylight.controller/sal-common-impl/1.7.0-SNAPSHOT</bundle>

Generated at Wed Feb 07 20:38:55 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.