[SFC-229] Neon-MRI: Bump odlparent, yangtools, mdsal Created: 04/Sep/18  Updated: 26/Oct/18  Due: 09/Oct/18  Resolved: 26/Oct/18

Status: Resolved
Project: sfc
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Medium
Reporter: Michael Vorburger Assignee: Brady Johnson
Resolution: Done Votes: 0
Labels: neon-mri
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks TSC-132 Neon MRI Integration Window Resolved
is blocked by ODLPARENT-163 Release odlparent 4.0.1 for Neon-MRI:... Resolved

 Description   

SFC part of https://git.opendaylight.org/gerrit/#/q/topic:neon-mri ...



 Comments   
Comment by Michael Vorburger [ 23/Sep/18 ]

FYI https://wiki.opendaylight.org/view/Neon_platform_upgrade has step-by-step instructions ...

Comment by Brady Johnson [ 24/Sep/18 ]

Here is the SFC patch:

https://git.opendaylight.org/gerrit/#/c/76404/

I locally built controller, aaa, netconf, and ovsdb. The ovsdb patch doesnt build locally yet.

The SFC patch doesnt build locally due to sfc-ovs, which depends on ovsdb.

Comment by Brady Johnson [ 24/Sep/18 ]

With Vishal's final changes to the OVSDB patch, and my final changes to the SFC patch, SFC is now building successfully.

Comment by Michael Vorburger [ 06/Oct/18 ]

ebrjohn I don't think so, https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/integration-multipatch-test-neon/54/console.log.gz fails with:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile (default-testCompile) on project sfc-genius-utils: Compilation failure: Compilation failure: 
[ERROR] /w/workspace/integration-multipatch-test-neon/patch_tester/sfc/sfc-util/sfc-genius-utils/src/test/java/org/opendaylight/sfc/genius/util/SfcGeniusDataUtilsTest.java:[39,88] package org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.iana._if.type.rev140508 does not exist
[ERROR] /w/workspace/integration-multipatch-test-neon/patch_tester/sfc/sfc-util/sfc-genius-utils/src/test/java/org/opendaylight/sfc/genius/util/SfcGeniusDataUtilsTest.java:[101,36] cannot find symbol
[ERROR]   symbol:   class L2vlan
[ERROR]   location: class org.opendaylight.sfc.genius.util.SfcGeniusDataUtilsTest
[ERROR] /w/workspace/integration-multipatch-test-neon/patch_tester/sfc/sfc-util/sfc-genius-utils/src/test/java/org/opendaylight/sfc/genius/util/SfcGeniusDataUtilsTest.java:[186,36] cannot find symbol
[ERROR]   symbol:   class L2vlan
[ERROR]   location: class org.opendaylight.sfc.genius.util.SfcGeniusDataUtilsTest
[ERROR] /w/workspace/integration-multipatch-test-neon/patch_tester/sfc/sfc-util/sfc-genius-utils/src/test/java/org/opendaylight/sfc/genius/util/SfcGeniusDataUtilsTest.java:[240,36] cannot find symbol
[ERROR]   symbol:   class L2vlan
[ERROR]   location: class org.opendaylight.sfc.genius.util.SfcGeniusDataUtilsTest
Comment by Brady Johnson [ 10/Oct/18 ]

Everything is building correctly, and all the UT are working correctly now.

Im down to 2 SingleFeatureTest failures:

 

odl-sfclisp

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 12.148 s <<< FAILURE! - in org.opendaylight.odlparent.featuretest.SingleFeatureTest
[ERROR] installFeatureCatchAndLog(org.opendaylight.odlparent.featuretest.SingleFeatureTest)[repoUrl: file:/home/bjohnson/projects/odl/sfc/features/odl-sfclisp/target/feature/feature.xml, Feature: odl-sfclisp 0.9.0.SNAPSHOT] Time elapsed: 10.696 s <<< ERROR!
org.apache.felix.resolver.reason.ReasonException: Unable to resolve org.opendaylight.sfc.lisp/0.9.0.SNAPSHOT: missing requirement [org.opendaylight.sfc.lisp/0.9.0.SNAPSHOT] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715)(version>=1.6.0)(!(version>=2.0.0)))"

 

odl-sfc-genius

 

[INFO] Running org.opendaylight.odlparent.featuretest.SingleFeatureTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 613.437 s <<< FAILURE! - in org.opendaylight.odlparent.featuretest.SingleFeatureTest
[ERROR] installFeatureCatchAndLog(org.opendaylight.odlparent.featuretest.SingleFeatureTest)[repoUrl: file:/home/bjohnson/projects/odl/sfc/features/odl-sfc-genius/target/feature/feature.xml, Feature: odl-sfc-genius 0.9.0.SNAPSHOT] Time elapsed: 611.231 s <<< ERROR!
java.lang.ClassNotFoundException: org.junit.runners.model.TestTimedOutException (no security manager: RMI class loader disabled)

 

Comment by Michael Vorburger [ 10/Oct/18 ]

The org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715)(version>=1.6.0)(!(version>=2.0.0)))" problem is probably related to something left over re. https://wiki.opendaylight.org/view/Neon_platform_upgrade#MD-SAL_Impacts somewhere in SFC... rovarga may have further input re. what's what here.

 
The java.lang.ClassNotFoundException: org.junit.runners.model.TestTimedOutException is just a symptom, see ODLPARENT-38; you'll want to look at your sfc/features/odl-sfc-genius/target/SFT/karaf.log to understand what's really going on.

Comment by Brady Johnson [ 10/Oct/18 ]

vorburger I attached the karaf.log for the odl-sfc-genius SFT, and cant find anything wrong. Could you take a look please?

Thanks,

Bradu

 

Comment by Michael Vorburger [ 10/Oct/18 ]

Had a look, but no clue, sorry... there is this, but note that from 2018-10-10T12:33:04,343 to 2018-10-10T12:43:04,130 there is a 10' - this NPE is not the cause, but just an effect of the SFT failure. It's curious that there are no other error indicating any feature problems... have you checked the surefire log to see if Pax Exam logged anything of interest there?
 

2018-10-10T12:43:04,130 | ERROR | Time-limited test | SingleFeatureTest | 87 - PAXEXAM-PROBE-a04408a4-dc78-4a4b-bdb8-da4bb0150984 - 0.0.0 | installFeature() failed java.lang.InterruptedException: null at java.util.concurrent.FutureTask.awaitDone(FutureTask.java:404) ~[?:?] at java.util.concurrent.FutureTask.get(FutureTask.java:191) ~[?:?] at org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvisionInThread(FeaturesServiceImpl.java:966) ~[?:?] at org.apache.karaf.features.internal.service.FeaturesServiceImpl.installFeatures(FeaturesServiceImpl.java:808) ~[?:?] at org.apache.karaf.features.internal.service.FeaturesServiceImpl.installFeatures(FeaturesServiceImpl.java:728) ~[?:?] at org.apache.karaf.features.internal.service.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:713) ~[?:?] at org.apache.karaf.features.internal.service.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:718) ~[?:?] at org.opendaylight.odlparent.featuretest.SingleFeatureTest.installFeature(SingleFeatureTest.java:391) ~[87:PAXEXAM-PROBE-a04408a4-dc78-4a4b-bdb8-da4bb0150984:0.0.0]
Comment by Brady Johnson [ 16/Oct/18 ]

As of patch set 11 submit to https://git.opendaylight.org/gerrit/#/c/76404/ on October 11th, the entire SFC projects builds (with mvn clean install) and all UT and SFT work.

Generated at Wed Feb 07 20:38:58 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.