Operating System: All
Platform: All

From: Maxime Millette Coulombe <mmcoulombe@inocybe.com>
Date: Tuesday, September 1, 2015 at 6:55 PM
To: Reinaldo Penno <rapenno@gmail.com>
Cc: "Harman Singh (harmasin)" <harmasin@cisco.com>, Brady Allen Johnson <brady.allen.johnson@ericsson.com>, Brady Johnson <bradyallenjohnson@gmail.com>, Edward Warnicke <hagbard@gmail.com>
Subject: Re: DLUX commit broke SFC-UI

Hi Reinaldo,

First of all, the way SFC-UI uses DLUX is not the proper way. It might break often.

I see in your repository that you have few files who are auto-generated by DLUX that you ignore.
After the release of lithium, the css has bump his version. It's now opendaylight-dlux-0.2.0.css and not opendaylight-dlux-0.1.0.css.
Also, we have done a little bit of cleanup and your index.html doesn't reflect those changes.

My suggestion will be to use the index.html from DLUX and use angular-css-injector to include your additional css file and also requirejs for your javascript file. It can be done in your sfc.module configuration callback function.

To conclude, I don't think we can support the way you use DLUX. DLUX has already a way to inject css and javascript to modify his behavior without impact other module. If someone of your team can join our weekly meeting it will be appreciate so we can discuss for a solution.

Best Regards,
—
Maxime Millette-Coulombe

Assigning to Dano.

Fix for this is in review.
https://git.opendaylight.org/gerrit/#/c/27276/

https://git.opendaylight.org/gerrit/#/c/27276/9

A patch has been supplied to fix this.