[SXP-155] SXP fails staging validation checker Created: 22/Nov/18 Updated: 23/Nov/18 Resolved: 23/Nov/18 |
|
| Status: | Resolved |
| Project: | sxp |
| Component/s: | General |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | High |
| Reporter: | Anil Belur | Assignee: | Thanh Ha (zxiiro) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0 minutes | ||
| Time Spent: | 1 hour | ||
| Original Estimate: | Not Specified | ||
| Description |
|
We have policies setup in Nexus that requires all staging repo artifacts to pass a series of validation checks before allowing them to be released. The following needs to be fixed, since the Nexus repos are failing to close when the repos are created through the maven stage jobs:
We've temporarily disabled the validation checker for the SXP project but it really needs to be enabled. We need to resolve the checkers ideally. |
| Comments |
| Comment by Thanh Ha (zxiiro) [ 22/Nov/18 ] |
|
I'm not sure how SXP is skipping the generation of source jars and javadoc jars as it's enabled in odlparent. Is SXP somehow overriding these in their builds? |
| Comment by Thanh Ha (zxiiro) [ 22/Nov/18 ] |
|
Pom Validation error is from: failureMessage Invalid POM: /org/opendaylight/sxp/restconf-client/0.1.1/restconf-client-0.1.1.pom: Project name missing, Project description missing, Project URL missing, License information missing, SCM URL missing, Developer information missing failureMessage Invalid POM: /org/opendaylight/sxp/sxp-jst/0.1.1/sxp-jst-0.1.1.pom: Project name missing, Project description missing, Project URL missing, License information missing, SCM URL missing, Developer information missing failureMessage Invalid POM: /org/opendaylight/sxp/sxp-system-tests/0.1.1/sxp-system-tests-0.1.1.pom: Project description missing, Project URL missing, License information missing, SCM URL missing, Developer information missing Sources Jar validation error is from: failureMessage Missing: no sources jar found in folder '/org/opendaylight/sxp/restconf-client/0.1.1' Javadoc validation error is from: failureMessage Missing: no javadoc jar found in folder '/org/opendaylight/sxp/restconf-client/0.1.1' |
| Comment by Thanh Ha (zxiiro) [ 22/Nov/18 ] |
|
Seems like these issues might stem from the files in the system-tests directory not having a parent which traces back to odlparent. I'm investigating adding odlparent-lite as their parent artifacts now. |
| Comment by Thanh Ha (zxiiro) [ 22/Nov/18 ] |
|
I submitted 3 patches to master, stable/fluorine, and stable/oxygen to hopefully resolve this issue. Can someone double check the copyrights to make sure they are correct? |
| Comment by Ivan Hrasko [ 22/Nov/18 ] |
|
Hi, I will check them. Copyrights are OK. |
| Comment by Thanh Ha (zxiiro) [ 22/Nov/18 ] |
|
I've re-enabled the validation checker. Let me know if you need me to do anything to get the master branch patch merged. |
| Comment by Ivan Hrasko [ 22/Nov/18 ] |
|
Patch on master branch was failing because using odl-parent as parent caused to run tests in: sxp-system-tests/sxp-jst/src/test/java/org/opendaylight/sxp/jst/SystemTests.java but they require running Karaf which is not satisfied during running unit tests.
I think system tests were marked as unit tests only for convenience to run them so I have reworked them: https://git.opendaylight.org/gerrit/#/c/78047/
And now it should be OK. |