[TOPOPROCES-25] Correlations are overwritten Created: 05/Jun/15  Updated: 19/Oct/17  Resolved: 03/Jul/15

Status: Resolved
Project: topoprocessing
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Michal Polkorab Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 3586

 Description   

Topoprocessing is designed to support multiple correlations at the same time. But when we use the same name (type) of correlation in overlay topology request - we end up only with one such correlation received in TopologyRequestHandler.

Can be tested with following input:
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<topology xmlns="urn:opendaylight:topology:correlation" xmlns:n="urn:TBD:params:xml:ns:yang:network-topology">
<n:topology-id>mytopo:1</n:topology-id>
<correlations>
<correlation>
<name>equality</name>
<correlation-item>node</correlation-item>
<equality>
<mapping>
<underlay-topology>mypcep:1</underlay-topology>
<target-field>network-topology-pcep:path-computation-client/network-topology-pcep:ip-address</target-field>
<aggregate-inside>false</aggregate-inside>
</mapping>
<mapping>
<underlay-topology>mypcep:2</underlay-topology>
<target-field>network-topology-pcep:path-computation-client/network-topology-pcep:ip-address</target-field>
<aggregate-inside>false</aggregate-inside>
</mapping>
</equality>
</correlation>
<correlation>
<name>equality</name>
<correlation-item>node</correlation-item>
<equality>
<mapping>
<underlay-topology>mypcep:3</underlay-topology>
<target-field>network-topology-pcep:path-computation-client/network-topology-pcep:ip-address</target-field>
<aggregate-inside>false</aggregate-inside>
</mapping>
<mapping>
<underlay-topology>mypcep:4</underlay-topology>
<target-field>network-topology-pcep:path-computation-client/network-topology-pcep:ip-address</target-field>
<aggregate-inside>false</aggregate-inside>
</mapping>
</equality>
</correlation>
</correlations>
</topology>



 Comments   
Comment by Michal Polkorab [ 05/Jun/15 ]

Problem is in key - which is only the name (and name can be same for more correlations). We should fix this issue by changing the key - possibly add order or id to differenciate

Comment by Michal Polkorab [ 03/Jul/15 ]

Fixed here: https://git.opendaylight.org/gerrit/#/c/22337/

Generated at Wed Feb 07 20:40:30 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.