[TRNSPRTPCE-115] Deleting node in clli-network Created: 06/May/19  Updated: 12/Jul/19  Resolved: 02/Jul/19

Status: Verified
Project: transportpce
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Medium
Reporter: Jonas Mårtensson Assignee: Olivier Renais
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: 0 minutes
Time Spent: 2 hours
Original Estimate: Not Specified


 Description   

As discussed in TRNSPRTPCE-86, deleting a node in topology-netconf automatically also deletes it in openroadm-network, which caused topology tests to fail. This has been fixed by removing manual node deletions in openroadm-network from the tests. However, in test_topology.py there is still manual node deletions in clli-network. Looking at the deleteOpenROADMnode function in NetworkModelServiceImpl.java, it seems to me that the intention there is to automatically delete nodes also in clli-network. But this deletion seems to reference the topology-netconf nodeId when the clli-network nodeId is the clli, which is different.

 Comments   
Comment by Jonas Mårtensson [ 11/Jun/19 ]

How was this resolved?

Comment by Olivier Renais [ 13/Jun/19 ]

Change back the status to unresolve since I am not sure we completely adress the comment.

Comment by Olivier Renais [ 13/Jun/19 ]

Agree with your view regarding what implements deleteOpenROADM Node. The intent is to delete the CLLI node as the Network node disappear. Fortunately there is a bug which leads at the end to the expected behavior (we try to delete a CLLI that corresponds to the node Id and does not exist : as an example if we have ROADMA in CLLI NodeA, we try to delete the CLLI ROADMA which does not exist). Indeed, we do not expect a CLLI to be removed from the topo just because one of the nodes hosted in this CLLI has disappeared. CLLI correspond to buildings/rooms. They are not supposed to be removed from the topology just becaus an equuipment in that room fails. Will put the bug in the next sprint (focused on topology and portmapping consolidation) and we will remove the function to delete CLLI.

Generated at Wed Feb 07 20:42:17 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.