[TRNSPRTPCE-22] Different values for TpId Created: 19/Jul/18 Updated: 03/Sep/21 Resolved: 12/Jul/19 |
|
| Status: | Verified |
| Project: | transportpce |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | High |
| Reporter: | Doha Khaled | Assignee: | Gilles Thouenon |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
in the ModeMappingUtils class - getNodesListAToZ and getNodesListZToA methods if the Resource in the AToZ or ZToA list are of type TERMINATION_POINT then there is a check on the TpId if containing the following values (PP, TTP, NETWOR or CLIENT) While after the initialization of servicePathInputDataAtoZ or servicePathInputDataZtoA Objects, in the deviceRendering method it calls the setupService method in the DeviceRendererServiceImpl class which compares the TpId to totally different Values stored in OpenRoadmInterfacesImpl class in the common module which are NETWORK_TOKEN = "XPDR-LINE"
we can fix and commit the issue by using the values in the OpenRoadmInterfacesImpl in all cases but we need confirmation from your side.
orenais guillaume.lambert martial.coulibaly gthouenon cbetoule
|
| Comments |
| Comment by Gilles Thouenon [ 19/Jul/18 ] |
|
Hi Doha, You highlight a crucial point inside TransportPCE regarding the consistency of TP naming between different modules (Renderer, OLM, Topology) which may have strong impact on the good level of working for PCE, Service Handler and so on. We are currently discussing this point with ATT, in order to have a common view of TPCE behavior regarding the OpenROADM recommandations. Personnaly, I think the naming containing "NETWORK, CLIENT" are the good ones. So, I think this is constants of OpenRoadmInterfacesImpl which need to be updated. Gilles |
| Comment by Doha Khaled [ 19/Jul/18 ] |
|
Dear Gilles, Thank you for your reply, we will use OpenRoadmInterfacesImpl in our test cases till the update happen |
| Comment by Gilles Thouenon [ 02/Jul/19 ] |
|
Obsolete. Has been solved through the different code evolutions. |
| Comment by Malick SYLLA [ 12/Jul/19 ] |
|
Not merged |