[TRNSPRTPCE-371] Compiling 7.1.0 common models Created: 04/Dec/20  Updated: 03/Sep/21  Resolved: 10/Dec/20

Status: Verified
Project: transportpce
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Medium
Reporter: Balagangadhar Bathula Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The newer 7.1.0 common models, have deprecated FEC identities which are differentiated with the current FEC identities using "-".

When complied on BSD based and Windows OS machines, it throws an error as below:

transportpce/ordmodels/common/target/generated-sources/mdsal-binding/org/opendaylight/yang/gen/v1/http/org/openroadm/common/types/rev200529/Ofec.java:[19,8] interface OFec is public, should be declared in a file named OFec.java
transportpce/ordmodels/common/target/generated-sources/mdsal-binding/org/opendaylight/yang/gen/v1/http/org/openroadm/common/types/rev200529/RsFec.java:[18,8] interface Rsfec is public, should be declared in a file named Rsfec.java
transportpce/ordmodels/common/target/generated-sources/mdsal-binding/org/opendaylight/yang/gen/v1/http/org/openroadm/common/types/rev200529/ScFec.java:[18,8] interface Scfec is public, should be declared in a file named Scfec.java

While compiling Ubuntu, it generates two classes for both deprecated and the current one and there is no error during the compilation. For example identity o-fec generates OFec.java and identity ofec generates Ofec.java respectively.



 Comments   
Comment by Robert Varga [ 07/Dec/20 ]

Using codegen on a case-insensitive filesystem is not supported and it never will be, exactly because the filesystem mangles Java naming.

Comment by Guillaume Lambert [ 07/Dec/20 ]

Thanks for the quick answer Robert !
I didn't know that Mac OS was using a case-preserving filesystem, which is case-insensitive indeed !

https://en.wikipedia.org/wiki/Case_sensitivity#In_filesystems

 

Comment by Balagangadhar Bathula [ 10/Dec/20 ]

Thanks rovarga and guillaume.lambert. I will close the issue now.

Comment by Balagangadhar Bathula [ 10/Dec/20 ]

The issue will be closed now. From next time we have to make sure that the YANG models does not have such naming convention that could fail in case-insensitive file systems.

Generated at Wed Feb 07 20:42:55 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.