[TSC-100] WriteTransaction.submit() to be annotated with @CheckReturnValue Created: 23/Apr/18  Updated: 30/Apr/19  Resolved: 07/May/18

Status: Resolved
Project: tsc
Component/s: None
Affects Version/s: None
Fix Version/s: Fluorine

Type: Weather Item Priority: Medium
Reporter: Robert Varga Assignee: Abhijit Kumbhare
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
is blocked by RELENG-103 integration-multipatch-test-fluorine ... Resolved
Relates
relates to CONTROLLER-1802 Reduce ConcurrentDOMDataBroker TX fai... Resolved
ODL Project: controller
ODL Release:
ODL Impacted Projects: all-projects
ODL Expected Date:

 Description   

As per the request in CONTROLLER-1802, the submit() method will be annotated with @CheckReturnValue. While this is not an API-compatible change, the added annotation can (and most probably will) trip FindBugs in cases when the code does not check the result of the transaction.



 Comments   
Comment by Robert Varga [ 23/Apr/18 ]

The patches are at https://git.opendaylight.org/gerrit/#/q/topic:CONTROLLER-1802+(status:open+OR+status:merged)

Comment by Michael Vorburger [ 30/Apr/18 ]

I'm running a first build on https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-fluorine/18/ to see which (first?) project is impacted by this change.

Comment by Michael Vorburger [ 30/Apr/18 ]

I don't think that worked / did the right thing; I'll first discuss it further with ecelgp in RELENG-103 instead of "polluting" this issue with more comments (until clarified).

Comment by Daniel Farrell [ 03/May/18 ]

vorburger says this has been verified to not break downstreams, can be merged.

Comment by Michael Vorburger [ 03/May/18 ]

https://lists.opendaylight.org/pipermail/controller-dev/2018-May/014377.html

https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-fluorine/25/

Comment by Robert Varga [ 07/May/18 ]

Patches have been merged and autorelease passed.

Generated at Wed Feb 07 20:45:09 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.