[TSC-101] MDSAL Fluorine API breakage window 3 Created: 24/Apr/18  Updated: 30/Apr/19  Resolved: 07/Jun/18

Status: Resolved
Project: tsc
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Weather Item Priority: Medium
Reporter: Robert Varga Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
is blocked by NETVIRT-1290 broken build due to StackOverflowErro... Resolved
is blocked by TSC-98 Binding V1 import tracking codegen ch... Resolved
is blocked by RELENG-126 multipatch doesn't stop if a build fails Closed
Relates
relates to MDSAL-2 Naming conflict appears when key of l... Resolved
ODL Project: mdsal
ODL Release:
ODL Impacted Projects: all-projects
ODL Expected Date:
ODL Managed Gerrit Topic: binding-tlc-getkey
ODL Last FULL Build: https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-fluorine/96/

 Description   

As per the plan outlined in https://lists.opendaylight.org/pipermail/mdsal-dev/2018-March/001519.html we MD-SAL is delivering this item:

2) Replace org.opendaylight.yangtools.yang.binding.Identifiable.getKey()

The full details are in the email, bottom line for downstreams is:

The solution is to rename getKey() to key(). As all user-governed names
in generated code is prefixed (with "is", "get" and similar), this will
permanently solve this particular problem. Unfortunately it will also
break all code which deals with getting/putting elements into keyed lists.

The fix is a mechanical one and probably scriptable (but I am not much
for writing scripts).

The fix also changes Augmentable.getAugmentation() to Augmentable.augmentation(). Proposed patches are at:

https://git.opendaylight.org/gerrit/#/q/topic:binding-tlc-getkey+(status:open+OR+status:merged)

 Comments   
Comment by Robert Varga [ 24/Apr/18 ]

Abhijit, we need to discuss timing of this on a TSC call

Comment by Michael Vorburger [ 04/May/18 ]

rovarga I have attempted to build topic:binding-tlc-getkey using a Multipatch Magic String (MMS?) created by The Bot, and it failed in mdsal already. Does this Managed Topic build on top of and require TSC-99 to get settled and over with, first?

Comment by Robert Varga [ 04/May/18 ]

It needs a proper rebase to work with import tracking, I suspect.

Comment by Michael Vorburger [ 08/May/18 ]

This is now blocked by DAEXIM, see https://lists.opendaylight.org/pipermail/daexim-dev/2018-May/000166.html

Comment by Michael Vorburger [ 14/May/18 ]

At bgpcep now, see https://lists.opendaylight.org/pipermail/bgpcep-dev/2018-May/001313.html

Comment by Michael Vorburger [ 15/May/18 ]

At ovsdb now, see https://lists.opendaylight.org/pipermail/ovsdb-dev/2018-May/004724.html

Comment by Vishal Thapar [ 16/May/18 ]

OVSDB patch [1] is failing mutlipatch test [2] due to merge conflicts in controller patch [3]. It passes when run with just the mdsal patches.

[1]https://git.opendaylight.org/gerrit/#/c/72021/
[2]https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-fluorine/48/console
[3]https://git.opendaylight.org/gerrit/71249

Comment by Michael Vorburger [ 24/May/18 ]

rovarga if you could rebase c/71255 and c/71259, then we can re-run a multipatch job to see who's up next on this one...

Comment by Robert Varga [ 24/May/18 ]

Done

Comment by Michael Vorburger [ 25/May/18 ]

https://lists.opendaylight.org/pipermail/bgpcep-dev/2018-May/001315.html

Comment by Michael Vorburger [ 31/May/18 ]

skitt says we need RELENG-126 here. 

Comment by Michael Vorburger [ 31/May/18 ]

https://lists.opendaylight.org/pipermail/bgpcep-dev/2018-May/001317.html

Comment by Michael Vorburger [ 01/Jun/18 ]

latest multipatch build (93) hit NETVIRT-1290 

Comment by Michael Vorburger [ 04/Jun/18 ]

skitt's latest multipatch #95 passes, so this is ready for a "simu-merge". So based on this email from shague, can we just let the releng team merge everything on topic:binding-tlc-getkey now? In the correct order, with waiting for merge jobs. (I dream of a future when The Bot will do this for us automatically.)

Comment by Stephen Kitt [ 04/Jun/18 ]

https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-fluorine/95/ built successfully; that was a -Pq build, so we know that the TSC-101 patches build successfully. I’ve started 96 which will be a slow build with all UTs.

Comment by Robert Varga [ 04/Jun/18 ]

We can get the ball rolling on offset-0s and let releng/US pickup as they wake up

Comment by Robert Varga [ 04/Jun/18 ]

MDSAL just went in, waiting for https://jenkins.opendaylight.org/releng/view/Merge-Jobs/job/mdsal-merge-fluorine/146 before rechecking controller.

Comment by Robert Varga [ 04/Jun/18 ]

Controller and AAA are merged.

Comment by Vishal Thapar [ 05/Jun/18 ]

All patches have been merged now - https://git.opendaylight.org/gerrit/#/q/topic:binding-tlc-getkey

Thanks Robert, Stephen and Michael.

Comment by Michael Vorburger [ 07/Jun/18 ]

all good

Generated at Wed Feb 07 20:45:10 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.