[TSC-115] MinimumBandwidthRule direction incorrectly defined in yang Created: 30/May/18  Updated: 02/Oct/19  Resolved: 04/Jun/18

Status: Resolved
Project: tsc
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Weather Item Priority: Medium
Reporter: Josh Hershberg Assignee: Josh Hershberg
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks NEUTRON-163 MinimumBandwidthRule direction incorr... Resolved
is blocked by RELENG-126 multipatch doesn't stop if a build fails Closed
ODL Project: neutron
ODL Release:
ODL Impacted Projects: Netvirt
ODL Expected Date:
ODL Managed Gerrit Topic: NEUTRON-163
ODL Last FULL Build: https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-fluorine/89/

 Description   

Description copied from: https://jira.opendaylight.org/browse/NEUTRON-163

 

In neutron-qos.yang minimumbandwidth-rule-attributes has a direction of type constants:direction-minimum-bandwidth-rule. However, that type is a "terminal node" with no inheriting directions. In addition, since direction appears in a few places there is no reason to not use the generic:

identity direction-base

{     description "Base identity for direction"; }

identity direction-ingress

{     description "Ingress direction.";     base direction-base; }

identity direction-egress

{     description "Egress direction.";     base direction-base; }

This change will require coordination with consumers of the existing yang model, e.g., netvirt and networking-odl.

h/t to Vishal Thapar for finding this

 Comments   
Comment by Michael Vorburger [ 31/May/18 ]

due to RELENG-126, I've canceled build #86 and launched #89 - tx skitt.

Comment by Michael Vorburger [ 31/May/18 ]

jhershbe (and thapar) the https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-fluorine/89/ passing proves that this (c/72460) doesn't have any build breaking impact on other managed projects. I would therefore suggest that this is not really a weather item - it doesn't break anyone, so this is a purely a (great!) Neutron internal fix (NEUTRON-163). Shall we close this TSC-115 Weather Item?

Generated at Wed Feb 07 20:45:13 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.