[TSC-99] MDSAL Fluorine API breakage window 2 Created: 22/Apr/18 Updated: 30/Apr/19 Resolved: 24/May/18 |
|
| Status: | Resolved |
| Project: | tsc |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Weather Item | Priority: | Medium |
| Reporter: | Robert Varga | Assignee: | Robert Varga |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| ODL Project: | mdsal | ||||||||
| ODL Release: | |||||||||
| ODL Impacted Projects: | all-projects | ||||||||
| ODL Expected Date: | |||||||||
| ODL Managed Gerrit Topic: | binding-tlc-rpc | ||||||||
| ODL Last FULL Build: | https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-fluorine/58 | ||||||||
| Description |
|
As per the plan outlined in https://lists.opendaylight.org/pipermail/mdsal-dev/2018-March/001519.html we MD-SAL is delivering this item: 3) Change the signature of generated RPC invocation methods The full details are in the email, bottom line for downstreams is: The third one will break implementations which do not specify ListenableFuture as their overridden return type or which do not return a subclass of ListenableFuture. The fix is largely a mechanical one. Proposed patches are at: https://git.opendaylight.org/gerrit/#/q/topic:binding-tlc-rpc+(status:open+OR+status:merged)
|
| Comments |
| Comment by Robert Varga [ 26/Apr/18 ] |
|
As per the discussion on today's TSC call, we are taking a stab at RELENG-101 before setting down the expected date. The date is expected to be set at the TSC call on May 3rd 2018. |
| Comment by Luis Gomez [ 30/Apr/18 ] |
|
This is what we have so far: I have successfully built list of patches of topic=binding-tlc-rpc: mdsal=55/69355/33:62/69362/30,controller=05/71205/6,aaa=19/71219/1,netconf=22/71222/2,bgpcep=27/71227/4 Next step could be either:
This is the list of projects we need a patch (in dependency order): |
| Comment by Michael Vorburger [ 30/Apr/18 ] |
|
based on our discussion in |
| Comment by Luis Gomez [ 30/Apr/18 ] |
|
I assumed all projects are affected by the breakage and the list above just comes from AR: |
| Comment by Michael Vorburger [ 30/Apr/18 ] |
|
I've just started a new https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-fluorine/21/ using this produced by https://github.com/vorburger/opendaylight-bot : Topic to be built binding-tlc-rpc:
Status | Change | Mergeable? | Subject | Project | Branch | Current Rev Ref
---------------------------------------------------------------------------------------------------------------------------------
MERGED | 71228 | N/A | Return ListenableFuture from RPCs | bgpcep | master | refs/changes/28/71228/1
NEW | 69355 | true | Always generate RPC input/output | mdsal | master | refs/changes/55/69355/33
NEW | 69362 | true | Make RPC implementations return ListenableFuture | mdsal | master | refs/changes/62/69362/30
NEW | 71205 | true | Adjust for Binding RPC codegen changes | controller | master | refs/changes/05/71205/6
NEW | 71219 | true | Adjust to RPC method signature update | aaa | master | refs/changes/19/71219/1
NEW | 71222 | true | Adjust to RPC method signature update | netconf | master | refs/changes/22/71222/2
NEW | 71227 | true | Adjust to RPC method signature update | bgpcep | master | refs/changes/27/71227/4
NEW | 71560 | true | TSC-99 Adjust to RPC method signature update | genius | master | refs/changes/60/71560/1
infrautils,mdsal:refs/changes/62/69362/30,mdsal:refs/changes/55/69355/33,controller:refs/changes/05/71205/6,aaa:refs/changes/19/71219/1,netconf:refs/changes/22/71222/2,daexim,bgpcep:refs/changes/27/71227/4,ovsdb,neutron,lispflowmapping,openflowplugin,coe,genius:refs/changes/60/71560/1,sfc,netvirt
|
| Comment by Michael Vorburger [ 03/May/18 ] |
|
Now waiting on lispflowmapping: https://lists.opendaylight.org/pipermail/lispflowmapping-dev/2018-May/001154.html |
| Comment by Michael Vorburger [ 14/May/18 ] |
|
FTR: I've helped project genius to work through some non-trivial adjustments needed by this one today. |
| Comment by Faseela K [ 15/May/18 ] |
|
ODL Last FULL Build : https://jenkins.opendaylight.org/releng/job/integration-multipatch-test-fluorine/44/ |
| Comment by Vishal Thapar [ 18/May/18 ] |
|
OVSDB doesn't have any RPCs so no OVSDB patch needed for this. |
| Comment by Faseela K [ 18/May/18 ] |
|
COE does not have any RPCs and it does not use RPCs from other projects as well, so no patch needed for |
| Comment by Faseela K [ 19/May/18 ] |
|
Multi patch job 58 has built successfully, and jluhrsen is running netvirt CSIT with the build generated :
|
| Comment by Robert Varga [ 23/May/18 ] |
|
All patches are in. This weather item can be resolved as soon as we have a successful autorelease build. |