Operating System: All
Platform: All

Good news and bad news.

Testing locally, odl-hbaseclient seems to pass SingleFeatureTest even when removed from the blacklist. The fix [0] is already merged.

But, a similar issue has appeared. Not sure if the issue is identical, as I cannot reproduce the original Tsdr exception.

The issue is caused by a specific patch set [1] for Yangtools, which causes SFT failure for odl-distribution-version (which is bad as that happens in distribution-check job, affecting every project). See the stack trace below.

The latest hypothesis (from Robert) is that the NoClassDefFoundError is a sign of java package name collision, in this case a leftover from MDSAL-200.

Section from surefire log [2]:

2017-03-09 13:50:47,287 | ERROR | ime-limited test | ConfigManagerActivator | 181 - org.opendaylight.controller.config-manager - 0.6.0.SNAPSHOT | Error starting config manager
java.lang.NoClassDefFoundError: org/opendaylight/mdsal/binding/generator/util/BindingRuntimeContext
at org.opendaylight.controller.config.manager.impl.osgi.mapping.BindingContextProvider.update(BindingContextProvider.java:25)
at org.opendaylight.controller.config.manager.impl.osgi.mapping.RefreshingSCPModuleInfoRegistry.updateService(RefreshingSCPModuleInfoRegistry.java:57)
at org.opendaylight.controller.config.manager.impl.osgi.mapping.ModuleInfoBundleTracker.open(ModuleInfoBundleTracker.java:57)
at org.opendaylight.controller.config.manager.impl.osgi.ConfigManagerActivator.start(ConfigManagerActivator.java:89)
at org.eclipse.osgi.framework.internal.core.BundleContextImpl$1.run(BundleContextImpl.java:711)
at java.security.AccessController.doPrivileged(Native Method)[:1.8.0_121]
at org.eclipse.osgi.framework.internal.core.BundleContextImpl.startActivator(BundleContextImpl.java:702)
at org.eclipse.osgi.framework.internal.core.BundleContextImpl.start(BundleContextImpl.java:683)
at org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.java:381)
at org.eclipse.osgi.framework.internal.core.AbstractBundle.start(AbstractBundle.java:300)
at org.eclipse.osgi.framework.internal.core.AbstractBundle.start(AbstractBundle.java:292)
at org.apache.karaf.features.internal.FeaturesServiceImpl.startBundle(FeaturesServiceImpl.java:516)
at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeatures(FeaturesServiceImpl.java:474)
at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:415)
at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:390)
at Proxy982bca3f_90e6_4d5a_8c60_3c8442644362.installFeature(Unknown Source)
at org.opendaylight.odlparent.featuretest.SingleFeatureTest.installFeature(SingleFeatureTest.java:338)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)[:1.8.0_121]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)[:1.8.0_121]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.8.0_121]
at java.lang.reflect.Method.invoke(Method.java:498)[:1.8.0_121]
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)[141:org.ops4j.pax.tipi.junit:4.12.0.1]
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)[141:org.ops4j.pax.tipi.junit:4.12.0.1]
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)[141:org.ops4j.pax.tipi.junit:4.12.0.1]
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)[141:org.ops4j.pax.tipi.junit:4.12.0.1]
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)[141:org.ops4j.pax.tipi.junit:4.12.0.1]
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)[141:org.ops4j.pax.tipi.junit:4.12.0.1]
at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_121]
at java.lang.Thread.run(Thread.java:745)[:1.8.0_121]
Caused by: java.lang.ClassNotFoundException: org.opendaylight.mdsal.binding.generator.util.BindingRuntimeContext
at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:455)
at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:421)
at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:412)
at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:107)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)[:1.8.0_121]
... 29 more

[0] https://git.opendaylight.org/gerrit/53138
[1] https://git.opendaylight.org/gerrit/#/c/53000/4
[2] https://logs.opendaylight.org/releng/jenkins092/yangtools-distribution-check-carbon/1758/archives/distribution/features-distribution/target/surefire-reports/org.opendaylight.odlparent.featuretest.SingleFeatureTest-output.txt.gz

Reverted in https://git.opendaylight.org/gerrit/53372

https://git.opendaylight.org/gerrit/#/c/53109/ probably fixes the problem this bug originally was about (first comment above) under Karaf 4 as a "side effect", so once that change will finally be merged, it would be worthwhile for someone interestd in TSDR (that's not me...) to retry this, and then probably be able to remove the black listed odl-hbaseclient from tsdr from SingleFeatureTest in features4-test. This is specific to Karaf 4 because of c/53109; under Karaf 3 in features-test it's likely still broken, but maybe we can just forget about that.

Vratko / Robert, I don't think I understand what your point above has to do with this; to me that problem (NoClassDefFoundError: org/opendaylight/mdsal/binding/generator/util/BindingRuntimeContext) looks like a completely separate issue.

The BindingRuntimeContext thing was a split package problem, fixed in https://git.opendaylight.org/gerrit/53140.

This is no longer an issue - odl-hbaseclient SFT runs fine now.