[VTN-1] Please convert System.out.println usage to proper log statements Created: 15/Jan/14  Updated: 03/May/18  Resolved: 16/Jan/14

Status: Resolved
Project: vtn
Component/s: Core
Affects Version/s: unspecified
Fix Version/s: None

Type: Improvement
Reporter: Ed Warnicke Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Mac OS
Platform: PC



 Description   

Please convert System.out.println usage to proper log statements:

Subdir vtn/
Running command: grep -rn System.out .
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:42: System.out.println("Number is converted from float in IpcDouble.");
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:88: System.out.println("Number is converted from double in IpcDouble.");
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:135: System.out.println("Number is converted from String in IpcDouble.");
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:407: System.out.println("Overlapped test pattern is "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:442: System.out.println(" Input:" + value +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:444: System.out.println(" float = " + value + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:446: System.out.println(" IpcDouble(float) = " + obj.floatValue() + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:450: System.out.println(" double casted = " + d + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:453: System.out.println(" IpcDouble = " + obj.doubleValue() + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:468: System.out.println(" Input:" + value +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:470: System.out.println(" Double = " + value + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:473: System.out.println(" IpcDouble = " + obj.doubleValue() + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:488: System.out.println(" Input:" + value +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:490: System.out.println(" IpcDouble = " + obj.doubleValue() + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java:493: System.out.println(" required float number = " + required + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:42: System.out.println("Number is converted from float in IpcFloat.");
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:88: System.out.println("Number is converted from double in IpcFloat.");
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:139: System.out.println("Number is converted from String in IpcFloat.");
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:407: System.out.println("Overlapped test pattern is "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:441: System.out.println(" Input:" + value +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:443: System.out.println(" float = " + value + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:445: System.out.println(" IpcFloat = " + obj.floatValue() + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:460: System.out.println(" Input:" + value +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:462: System.out.println(" double = " + value + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:465: System.out.println(" IpcFloat(double) = " +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:471: System.out.println(" float casted = " + f + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:474: System.out.println(" IpcFloat(float) = " + obj.floatValue() + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:489: System.out.println(" Input:" + value +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:491: System.out.println(" IpcFloat = " + obj.floatValue() + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java:494: System.out.println(" required float number = " + required + " (" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcInet4AddressTest.java:277: System.out.println("Overlapped test pattern is "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcInet6AddressTest.java:315: System.out.println("Overlapped test pattern is "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcInt16Test.java:163: System.out.println("Statistics for Comparing patterns "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcInt16Test.java:165: System.out.println(" Equal - " + comp_counts[0] +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcInt32Test.java:186: System.out.println("Statistics for Comparing patterns "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcInt32Test.java:188: System.out.println(" Equal - " + comp_counts[0] +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcInt32Test.java:234: System.out.println("Overlapped test pattern is "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcInt64Test.java:191: System.out.println("Statistics for Comparing patterns "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcInt64Test.java:193: System.out.println(" Equal - " + comp_counts[0] +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcInt64Test.java:239: System.out.println("Overlapped test pattern is "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcUint16Test.java:181: System.out.println("Statistics for Comparing patterns "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcUint16Test.java:183: System.out.println(" Equal - " + comp_counts[0] +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcUint32Test.java:216: System.out.println("Statistics for Comparing patterns "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcUint32Test.java:218: System.out.println(" Equal - " + comp_counts[0] +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcUint32Test.java:264: System.out.println("Overlapped test pattern is "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcUint64Test.java:175: System.out.println("Statistics for Comparing patterns "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcUint64Test.java:178: System.out.println(" Pattern " + (pat + 1) + ":" +
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcUint64Test.java:239: System.out.println("Overlapped test pattern is "
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/TestBase.java:284: System.out.println(line);
./coordinator/core/test/java/pfc_util/src/org/opendaylight/vtn/core/util/TestBase.java:267: System.out.println(line);
./manager/implementation/src/test/java/org/opendaylight/vtn/manager/internal/TestStub.java:848: System.out.println("deserialize failed.");
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:262: System.out.println("HTTP method: " + method + " url: " + restUrl.toString());
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:264: System.out.println("body" + body);
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:321: System.out.println("HTTP response code: " + connection.getResponseCode());
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:322: System.out.println("HTTP response message: " + connection.getResponseMessage());
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:365: System.out.println("Starting VTN JAXB client.");
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:958: System.out.println("Starting vBridge JAXB client.");
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:1465: System.out.println("Starting vBridge Intergace JAXB client.");
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:1931: System.out.println("Starting delete vBridge Intergace JAXB client.");
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:2007: System.out.println("Starting Port Mapping JAXB client.");
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:2325: System.out.println("Starting delete Port Mapping JAXB client.");
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:2377: System.out.println("Starting VLAN Mapping JAXB client.");
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:2719: System.out.println("Starting delete Port Mapping JAXB client.");
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:2794: System.out.println("Starting MAC address JAXB client.");
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:3021: System.out.println("Starting IVTNGlobal JAXB client.");
./manager/northboundIT/src/test/java/org/opendaylight/vtn/manager/northbound/integrationtest/VtnNorthboundIT.java:3063: System.out.println("Starting Test with Service Unavailable.");



 Comments   
Comment by Hideyuki Tai [ 16/Jan/14 ]

The following patch has eliminated all System.out.println.

https://git.opendaylight.org/gerrit/#/c/4258/

Comment by Hideyuki Tai [ 16/Jan/14 ]

I executed the following command to confirm that all System.out.println is removed.

$ git log | head
commit 51b9cecd6dc0bc053f350d05b096e7a8ba6fbd83
Merge: 4bb1b56 20bc3f8
Author: Hideyuki Tai <h-tai@cd.jp.nec.com>
Date: Thu Jan 16 09:34:47 2014 +0000

Merge "Eliminate direct output to the standard output stream from tests."

commit 4bb1b5661f5b99a3dfd7ffc126acba6c0684499f
Merge: 330659b ea412f0
Author: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

$ grep -rn System.out . | wc
0 0 0

Generated at Wed Feb 07 20:47:43 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.