The CSIT flow filter test case is failing in the verification of action ICMP code and type in flowentreis

Order of Test scenarios execution
• VTN Flow filter
• vBridge Flow filter
• vBridge Interface flow filter.

Topology used
h1,h2 <--> s2 <-> s1 <-> s3 <--> h3,h4

Following are the steps followed in the CSIT test script for both OF10 and OF13.

1. Create Tenant1
2. Create vBridge1
3. Create interfaces(if1 and if2) in vBridge1
4. Create portmapping for if1 and if2.
5. Ping h1 and h3
6. Verify Ping success
7. Create vBridge2,
8. Create interfaces(if3and if4) in Vbridge 2,
9. Create portmapping for if3 and if4.
10. Ping h3 and h4
11. Verify ping success
12. Add flow condition to match h1, h3 ip address
13. Add VTN flowfilter to set flow action ("vtn-set-icmp-code-action" and "vtn-set-icmp-type-action")
14. Ping h1 and h3
15. Verify ping failure
16. Read the flow entries in mininet switch s3 to verify actions=mod_tp_dst and mod_tp_src are set or not.
17. Remove VTN Flowfilter index which has ICMP values
18. Add VBR flowfilter to set flow action ("vtn-set-icmp-code-action" and "vtn-set-icmp-type-action")
19. Ping h1 and h3
20. Verify ping failure
21. Read the flow entries in mininet switch s3 to verify actions=mod_tp_dst and mod_tp_src are set or not.
22. Remove VTN Flowfilter index which has ICMP values
23. Add VBRIf flowfilter in If1 to set flow action ("vtn-set-icmp-code-action" and "vtn-set-icmp-type-action")
24. Ping h1 and h3
25. Verify ping failure
26. Read the flow entries in mininet switch s3 to verify actions=mod_tp_dst and mod_tp_src are set or not.
27 Remove VTN Flowfilter index which has ICMP values
28. Delete flow condition
29. Delete vtn1

In the above steps, Test cases failed in the below cases.

For OF10:
In step 15, step 19 and step 23 we are expecting verify ping failure(mininet ping should not success between hosts h1 and h3) but pinging between hosts which makes test failures.
Because we have set action ICMP type=3 and cpde =1 which defines destination unreachable.

For OF13:
In step 16, step 20 and step 24 reading the flow entries in mininet switch s3 to verify actions=mod_tp_dst and mod_tp_src are set or not. But test cases fails and in mininet flows ICMP code and type values(mod_tp_src and mod_tp_dst) are not set.

To understand the above issues, analyzed karaf log for VTN Manager module while the above steps were executed. Flow entry were installed with ICMP values and removed only when remove flowfilter cases were excuted. But test fails only when verifying flows in mininet.
Attached log as zip file icmp_karaf.zip:
karaf log file name -> icmp_karaf.log

For OF10:
VTN Flow filter - Test steps 13-17
a) Flow entry install request is issued in line 2444 at time stamp 2016-03-23 05:43:14,065
b) Flow entries remove request has be issued in line 2648 at time stamp 2016-03-23 05:43:35,214

VBR Flow filter – Test steps 18 – 22
a) Flow entry install request is issued in line 2720 at time stamp 2016-03-23 05:43:35,263
b) Flow entries remove request has be issued in line 2927 at time stamp 2016-03-23 05:43:56,464

VBRIF Flow filter – Test steps 23 – 27
a) Flow entry install request is issued in line 2996 at time stamp 2016-03-23 05:43:56,507
b) Flow entries remove request has be issued in line 3167 at time stamp 2016-03-23 05:44:17,695

For OF13:
VTN Flow filter - Test steps 13-17
a) Flow entry install request is issued in line 6832 at time stamp 2016-03-23 05:48:03,683
b) Flow entries remove request has be issued in line 7036 at time stamp 2016-03-23 05:48:36,091

VBR Flow filter – Test steps 18 – 22
a) Flow entry install request is issued in line 7092 at time stamp 2016-03-23 05:48:36,130
b) Flow entries remove request has be issued in line 7236 at time stamp 2016-03-23 05:49:09,014

VBRIF Flow filter – Test steps 23 – 27
a) Flow entry install request is issued in line 7286 at time stamp 2016-03-23 05:49:09,053
b) Flow entries remove request has be issued in line 7484 at time stamp 2016-03-23 05:49:41,478

Copied dumpflow output from Mininet in Sandbox:

dump-flow log for OF10 in switch s3: Here we can see ICMP code and type value set as actions=mod_tp_dst:1,mod_tp_src:3

• • • s3 ------------------------------------------------------------------------
      NXST_FLOW reply (xid=0x4):
      cookie=0x7f5600000000000e, duration=21.079s, table=0, n_packets=19, n_bytes=1862, idle_age=1, priority=14,icmp,in_port=3,vlan_tci=0x0000,dl_src=86:1f:a7:79:cb:69,dl_dst=46:fa:9e:28:b0:12,nw_src=10.0.0.1,nw_dst=10.0.0.3 actions=mod_tp_dst:1,mod_tp_src:3,output:1 <<-------------
      cookie=0x7f5600000000000f, duration=20.106s, table=0, n_packets=18, n_bytes=1764, idle_timeout=300, idle_age=1, priority=12,ip,in_port=1,vlan_tci=0x0000,dl_src=46:fa:9e:28:b0:12,dl_dst=86:1f:a7:79:cb:69,nw_src=10.0.0.3 actions=output:3
      cookie=0x7f56000000000010, duration=15.094s, table=0, n_packets=0, n_bytes=0, idle_timeout=300, idle_age=15, priority=11,arp,in_port=1,vlan_tci=0x0000,dl_src=46:fa:9e:28:b0:12,dl_dst=86:1f:a7:79:cb:69 actions=output:3
      cookie=0x7f56000000000011, duration=15.091s, table=0, n_packets=0, n_bytes=0, idle_age=15, priority=11,arp,in_port=3,vlan_tci=0x0000,dl_src=86:1f:a7:79:cb:69,dl_dst=46:fa:9e:28:b0:12 actions=output:1

dump-flow log for OF13 in switch s3: Here ICMP code and type values are not set in flowentries.

• • • s3 ------------------------------------------------------------------------
      OFPST_FLOW reply (OF1.3) (xid=0x2):
      cookie=0x7f57ffffffffffff, duration=73.772s, table=0, n_packets=75, n_bytes=5612, send_flow_rem priority=0 actions=CONTROLLER:65535
      cookie=0x7f56000000000037, duration=24.247s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=11,arp,in_port=3,vlan_tci=0x0000/0x1fff,dl_src=26:33:e6:4b:32:58,dl_dst=86:d0:90:26:f9:06 actions=output:1
      cookie=0x7f56000000000038, duration=24.242s, table=0, n_packets=0, n_bytes=0, idle_timeout=300, send_flow_rem priority=11,arp,in_port=1,vlan_tci=0x0000/0x1fff,dl_src=86:d0:90:26:f9:06,dl_dst=26:33:e6:4b:32:58 actions=output:3
      mininet>

Attached karaf log file as icmp_karaf.zip