[VTN-87] VTN Manager depends on missing dependencies Created: 07/Oct/15  Updated: 19/Oct/17  Resolved: 11/Dec/15

Status: Verified
Project: vtn
Component/s: VTN Manager
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Thanh Ha (zxiiro) Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 4426

 Description   

See: https://jenkins.opendaylight.org/releng/job/autorelease-daily-beryllium/214/org.opendaylight.vtn$manager/console

VTN Manager appears to be pulling in dependencies that are missing from the build. In autorelease we caught the following 2 dependencies:

[WARNING] The POM for org.opendaylight.controller:sal:jar:0.10.0-Daily-v201510070746 is missing, no dependency information available

[WARNING] The POM for org.opendaylight.controller:hosttracker:jar:0.7.0-Daily-v201510070746 is missing, no dependency information available



 Comments   
Comment by Hideyuki Tai [ 07/Oct/15 ]

I've investigated this failure.

The reason of the failure is that the VTN project is depending AD-SAL artifacts which does not exist anymore in the master branch of the controller project.
In Beryllium, VTN project plans to remove that dependency by the M4 (11/12).

Therefore, I think we should temporarily remove the VTN project from the autorelease job to avoid that build failure.
Otherwise, we need to ask the controller project to revert the following patch which deleted the AD-SAL artifacts to get back the artifacts.
https://git.opendaylight.org/gerrit/#/c/18740/

Note:
Basically, VTN builds on the master branch works fine.
https://jenkins.opendaylight.org/releng/view/vtn/job/vtn-integration-beryllium/

That's because VTN builds can use SNAPSHOT artifacts of the AD-SAL from the NEXUS repository.
For example, org.opendaylight.controller:sal:jar:0.10.0-SNAPSHOT is available at the following location.
https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/controller/sal/0.10.0-SNAPSHOT/

However, since the autorelease job does not use these SNAPSHOT artifacts at the NEXUS repository, the build failure occurred.

Comment by Thanh Ha (zxiiro) [ 07/Oct/15 ]

This patch which temporarily disables VTN from autorelease should be reverted when this bug is resolved:

https://git.opendaylight.org/gerrit/28022/

Comment by Tony Tkacik [ 21/Oct/15 ]

Hideyuiki,
you could use last released AD-SAL components, which are Lithium-based instead of Be SNAPSHOTs (which as you pointed out does not exists anymore).

Comment by Vratko Polak [ 05/Nov/15 ]

> you could use last released AD-SAL components, which are Lithium-based instead of Be SNAPSHOTs

Oh, I forgot to comment on this.
1. I do not think Beryllium autorelease job has access to Lithium released artifacts.
2. Even if it has, I do not think it is desirable to pull different version of third party dependecies. For example Netty has version 4.0.26.Final in Lithium [0], but 4.0.30.Final in current Beryllium [1].

Other than that, it may work as emergency measure for now.

[0] https://nexus.opendaylight.org/content/repositories/opendaylight.release/org/opendaylight/controller/features-base/1.5.2-Lithium-SR2/features-base-1.5.2-Lithium-SR2-features.xml

[1] https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/controller/features-config/0.4.0-SNAPSHOT/features-config-0.4.0-20151103.215908-326-features.xml

Comment by Thanh Ha (zxiiro) [ 24/Nov/15 ]

According to [1] VTN will remove AD-SAL by 2015-12-03.

[1] https://lists.opendaylight.org/pipermail/release/2015-November/004455.html

Comment by Thanh Ha (zxiiro) [ 24/Nov/15 ]

Hideyuki, any updates on this other than the one I link from comment 5?

Please keep us posted so we can re-enable VTN in autorelease.

Comment by Hideyuki Tai [ 24/Nov/15 ]

(In reply to Thanh Ha from comment #6)
> Hideyuki, any updates on this other than the one I link from comment 5?
>
> Please keep us posted so we can re-enable VTN in autorelease.

It's not yet done.
I think we can completely delete AD-SAL dependencies by the end of this month.

Just for your information, we've merged a huge patch for the migration yesterday. The most work for the migration was completed in the patch. That was really heavy task.
https://git.opendaylight.org/gerrit/#/c/30033/
The day is really close.

Comment by Vratko Polak [ 02/Dec/15 ]

I did some investigation. Something like this is still needed: https://git.opendaylight.org/gerrit/30495

Comment by Hideyuki Tai [ 02/Dec/15 ]

(In reply to Vratko Polák from comment #8)
> I did some investigation. Something like this is still needed:
> https://git.opendaylight.org/gerrit/30495

Thank you for your investigation.

Our work for removing AD-SAL dependencies has not been completed yet.

The following patch is removing AD-SAL dependencies.
https://git.opendaylight.org/gerrit/#/c/30476/
Of course, this patch include your change.

We are reviewing this patch.
I think we would merge the patch soon.

Comment by Hideyuki Tai [ 02/Dec/15 ]

We've completed the removal of the AD-SAL dependencies from VTN on the master branch (for Beryllium).

https://git.opendaylight.org/gerrit/#/c/30476/

Now, VTN on the master branch does not depend on AD-SAL anymore.

Comment by Hideyuki Tai [ 02/Dec/15 ]

(In reply to Thanh Ha from comment #2)
> This patch which temporarily disables VTN from autorelease should be
> reverted when this bug is resolved:
>
> https://git.opendaylight.org/gerrit/28022/

To revert the above change, I push the following patch.
https://git.opendaylight.org/gerrit/#/c/30509/
This needs to be reviewed by a committer of the autorelease project.

Comment by Thanh Ha (zxiiro) [ 02/Dec/15 ]

(In reply to Hideyuki Tai from comment #11)
> (In reply to Thanh Ha from comment #2)
> > This patch which temporarily disables VTN from autorelease should be
> > reverted when this bug is resolved:
> >
> > https://git.opendaylight.org/gerrit/28022/
>
> To revert the above change, I push the following patch.
> https://git.opendaylight.org/gerrit/#/c/30509/
> This needs to be reviewed by a committer of the autorelease project.

Thanks Hideyuki, it's been merged now. Hopefully we can get autorelease to build soon, I'm still waiting on a SNBI blocking patch [1] before we can see where we are at with autorelease.

[1] https://git.opendaylight.org/gerrit/30477/

Comment by Hideyuki Tai [ 11/Dec/15 ]

I've confirmed that VTN build succeeds in autorelease job.

https://jenkins.opendaylight.org/releng/job/autorelease-daily-beryllium/313/

Comment by Thanh Ha (zxiiro) [ 11/Dec/15 ]

Confirmed that autorelease passed:

https://jenkins.opendaylight.org/releng/job/autorelease-daily-beryllium/lastSuccessfulBuild/

Comment by Thanh Ha (zxiiro) [ 11/Dec/15 ]

Link should have been:

https://jenkins.opendaylight.org/releng/job/autorelease-daily-beryllium/313/

Generated at Wed Feb 07 20:47:59 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.