Eliminate duplicate DescriptionEffectiveStatementImpl objects (YANGTOOLS-694)

[YANGTOOLS-1121] Cleanup AbstractStatementSupport implementation Created: 03/Jul/20  Updated: 30/Oct/20  Resolved: 22/Aug/20

Status: Resolved
Project: yangtools
Component/s: parser
Affects Version/s: None
Fix Version/s: 6.0.0

Type: Sub-task Priority: Medium
Reporter: Robert Varga Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
is blocked by YANGTOOLS-1122 Refactor ExtensionEffectiveStatementI... Resolved
is blocked by YANGTOOLS-1123 Provide alternative to UnknownEffecti... Resolved

 Description   

We currently have multiple StatementSupport implementation bases:

  • AbstractStatementSupport
  • AbstractQNameStatementSupport
  • BaseStatementSupport
  • BaseQNameStatementSupport

The latter two provide integrated substatement management, hence should end up being the only entrypoints we are really using.

Remove the former two, along with AbstractDeclaredStatement (from SPI), so that we have complete control of substatement creation. Consider promoting Base* to their SPI Abstract* counterparts if it provides a benefit.

 Comments   
Comment by Robert Varga [ 22/Aug/20 ]

We retain AbstractStatementSupport for now, as we are still using it in two cases in the RFC7950 implementation.

Generated at Wed Feb 07 20:55:14 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.