[YANGTOOLS-1216] Require QName instead of SchemaPath for TypeDefinition implementions Created: 28/Jan/21 Updated: 28/Jan/21 Resolved: 28/Jan/21 |
|
| Status: | Resolved |
| Project: | yangtools |
| Component/s: | model-util |
| Affects Version/s: | None |
| Fix Version/s: | 7.0.0 |
| Type: | Improvement | Priority: | Medium |
| Reporter: | Robert Varga | Assignee: | Robert Varga |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | Get rid of SchemaNode.getPath() | ||||||||
| Description |
|
TypeDefinition has no semantics dependent on SchemaPath, just QName – ever since Since https://git.opendaylight.org/gerrit/q/I3490d6d706113ea14ee3f4181a7ba827380c8181 the default SchemaPath contract throws an UOE. This makes TypeDefinition.getPath() a pure implementation detail. This ends up being costly in terms of memory overhead (SchemaPath vs QName) as well as accidental mis-features, such as seemingly guaranteeing type definition uniqueness. |
| Comments |
| Comment by Robert Varga [ 28/Jan/21 ] |
|
We ended up disabling the test for SchemaContextUtil – it will be re-enabled with |