[YANGTOOLS-1396] Refactor IfFeaturePredicateVisitor Created: 08/Feb/22 Updated: 27/Jun/22 Resolved: 17/May/22 |
|
| Status: | Resolved |
| Project: | yangtools |
| Component/s: | parser |
| Affects Version/s: | None |
| Fix Version/s: | 9.0.0 |
| Type: | Improvement | Priority: | Medium |
| Reporter: | Robert Varga | Assignee: | Samuel Schneider |
| Resolution: | Done | Votes: | 0 |
| Labels: | pt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
IfFeaturePredicateVisitor is the only class requiring ANTLR's visitors to be generated. Refactor it to work purely on IfFeatureExpressionParser so that we can ditch visitors. This needs to work similarly as our other parsers work: by closely examining the shape of the parse tree, making assertions on what is valid and what not and having a nice method for each type of node encountered. |