[YANGTOOLS-183] yang-maven-plugin-it may fail if build is called with the -s settings Created: 09/Jun/14  Updated: 10/Apr/22  Resolved: 17/Sep/15

Status: Resolved
Project: yangtools
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement
Reporter: Giovanni Meo Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All



 Description   

Lets assume you want to build yangtools with a user setting file different that the one assumed by maven, like in the case of autorelease. So let say we call the build with:

mvn -s mysettings.xml clean install

lets assume mysettings.xml is defining some mirrors or adding extra repos, the yang-maven-plugin-it may fail in the execution of:

yang/yang-maven-plugin-it/src/test/java/org/opendaylight/yangtools/yang2sources/plugin/it/YangToSourcesPluginTestIT.java

when resolving artifacts in the org.apache.maven.it.Verifier invocation, because the settings.xml supplied in the build is not considered in the Verifier invocation.

The fix to this would be to apply the verifier.addCliOptions("-s " + filesettings);

assuming that the surefire/failsafe plugin could get that from the parent execution, or by passing an environment variable.

The first option even if more easy to understand will stumble upon:
https://jira.codehaus.org/browse/SUREFIRE-790

while the second one is not very convenient because will proliferate variables to just pass the settings to a sub-maven process.
The bug is opened mostly for tracking of the issue, and maybe because someone could find a smart way to address it.



 Comments   
Comment by Robert Varga [ 18/Mar/15 ]

Improvement, cannot commit to a release right now.

Comment by Robert Varga [ 17/Sep/15 ]

Addressed in https://git.opendaylight.org/gerrit/26653, the location of the settings files are picked up from environment.

Generated at Wed Feb 07 20:52:30 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.