[YANGTOOLS-205] Revisit ANTLR gramatic - cleanup and document it Created: 04/Jul/14  Updated: 10/Apr/22  Resolved: 09/Feb/15

Status: Resolved
Project: yangtools
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement
Reporter: Tony Tkacik Assignee: Martin Ciglan
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Windows
Platform: PC

Issue Links:
Blocks
blocks MDSAL-55 Topic: Continuos: Decrease technical ... Resolved
blocks YANGTOOLS-361 Milestone: Decrease Technical Debt fr... Resolved

 Description   

YANG Gramatic and all ANTLR related utils needs to be revisited for correctness
cleaned-up be be better maintainable and document.

All assumptions between code and gramatic must be documented, so it
is clear to maintainers and reviewers how gramatic work.

 Comments   
Comment by Tony Tkacik [ 13/Nov/14 ]

Added as blocking issue for Topic: Decrease Technical Debt.

Comment by Martin Ciglan [ 20/Nov/14 ]

ANTLR4 grammar audit in progress
if new obvious issue is found, new bug is open

Comment by Martin Ciglan [ 25/Nov/14 ]

Based on review, these bugs were open:

https://bugs.opendaylight.org/show_bug.cgi?id=2431

https://bugs.opendaylight.org/show_bug.cgi?id=2432

Moreover, arg-strings were identified in RFC6020, documented and will be provided.

Comment by Martin Ciglan [ 27/Nov/14 ]

arg-strings not handled (validated) in grammar, but in static methods of parser util class BasicValidations, called from YangModelBasicValidationListener class.

Review in progress, link between grammar and Java will be provided as comment in grammar file.

Comment by Martin Ciglan [ 16/Dec/14 ]

not to forget, comments pushed:

https://git.opendaylight.org/gerrit/#/c/13307

Comment by Martin Ciglan [ 22/Jan/15 ]

https://git.opendaylight.org/gerrit/#/c/13307/6

Generated at Wed Feb 07 20:52:34 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.