[YANGTOOLS-343] Incorrect override of getUnknownNodes in TypeDefinitionBuilderImpl Created: 20/Oct/14  Updated: 10/Apr/22  Resolved: 23/Oct/14

Status: Resolved
Project: yangtools
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Lukas Sedlak Assignee: Peter Kajsa
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 2220

 Description   

Method getUnknownNodes is implemented in AbstractBuilder and should return list of added UnknownSchemaNodeBuilders. The TypeDefinitionBuilderImpl extends AbstractTypeAwareBuilder which extends AbstractBuilder.

In TypeDefinitionBuilderImpl there is override of getUnknownNodes method which returns Collections.emptyList(). If this is intentional it should be at least commented since it brings confusion into code. If it is not intentional the override method should be removed from TypeDefinitionBuilderImpl.

There is no possibility to copy of TypedefinitionBuilders UnknownNodes in CopyUtils.java for copy TypDefinitionBuilder since the getUnknownNodes will always be an empty list.



 Comments   
Comment by Peter Kajsa [ 23/Oct/14 ]

fixed: https://git.opendaylight.org/gerrit/#/c/12157/

Generated at Wed Feb 07 20:52:57 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.